After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709091 - Forgetting network functionality in wifi history dialog is broken
Forgetting network functionality in wifi history dialog is broken
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-30 13:01 UTC by Rui Matos
Modified: 2013-10-01 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Just dismiss forget dialog if response is not OK (985 bytes, patch)
2013-09-30 13:01 UTC, Rui Matos 		committed Details | Review
network: Get the correct widget holding the "connection" object data (974 bytes, patch)
2013-09-30 13:01 UTC, Rui Matos 		reviewed Details | Review
network: Get the correct widget holding the "connection" object data (1.22 KB, patch)
2013-09-30 14:58 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-09-30 13:01:09 UTC 
Forgetting networks doesn't work and instead we get a critical and
empty rows.
Comment 1 Rui Matos 2013-09-30 13:01:12 UTC 
Created attachment 256079 [details] [review]
network: Just dismiss forget dialog if response is not OK

If the dialog is deleted, for instance, we don't want to take that as
OK.
Comment 2 Rui Matos 2013-09-30 13:01:17 UTC 
Created attachment 256080 [details] [review]
network: Get the correct widget holding the "connection" object data
Comment 3 Bastien Nocera 2013-09-30 13:09:18 UTC 
Review of attachment 256079 [details] [review]:

Yep.
Comment 4 Bastien Nocera 2013-09-30 13:11:48 UTC 
Review of attachment 256080 [details] [review]:

What does this fix? Better commit log please.
Comment 5 Rui Matos 2013-09-30 14:58:19 UTC 
Created attachment 256093 [details] [review]
network: Get the correct widget holding the "connection" object data

The check button isn't a direct child of the GtkListBoxRow instance
that contains the "connection" object data so we are adding the wrong
widget to the "rows" list which then gives us a NULL for "connection"
in really_forget() and making us fail to remove the connection.
Comment 6 Bastien Nocera 2013-09-30 15:20:40 UTC 
Review of attachment 256093 [details] [review]:

Yes.
Comment 7 Rui Matos 2013-10-01 13:11:41 UTC 
Attachment 256079 [details] pushed as b68f742 - network: Just dismiss forget dialog if response is not OK
Attachment 256093 [details] pushed as 1650293 - network: Get the correct widget holding the "connection" object data