After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709068 - Fn+F7 shows a dialogue when nothing changed
Fn+F7 shows a dialogue when nothing changed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-30 08:03 UTC by Bastien Nocera
Modified: 2013-10-03 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xrandr: remove persistent configuration supports (2.66 KB, patch)
2013-10-02 17:09 UTC, Giovanni Campagna 		committed Details | Review

Description Bastien Nocera 2013-09-30 08:03:00 UTC 
Pressing Fn+F7 (the "external screen" magic button) asks me whether I want to keep those display settings, except that nothing changed, my internal laptop monitor is still the only output, with the same resolution.

$ xrandr -q > foo
<Press Fn+F7 and accept the changes>
$ xrandr -q > foo2
$ diff -up foo foo2
$
Comment 1 Giovanni Campagna 2013-10-02 17:04:59 UTC 
Actually, the behavior should be that you don't get a dialog even if something changes, because the change is not persistent.

Except that gnome-settings-daemon actually requests a persistent change, for some reason (bad rebase or boolean confusion probably)
Comment 2 Giovanni Campagna 2013-10-02 17:09:20 UTC 
Created attachment 256301 [details] [review]
xrandr: remove persistent configuration supports

Configurations generated by rotate buttons or FN+F7 are always
temporary, so we should not ask mutter for a persistent one
instead.
Comment 3 Bastien Nocera 2013-10-03 13:14:31 UTC 
Review of attachment 256301 [details] [review]:

Looks good.
Comment 4 Giovanni Campagna 2013-10-03 13:17:00 UTC 
Attachment 256301 [details] pushed as 4cae494 - xrandr: remove persistent configuration supports