After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709060 - Consider upstreaming vte_terminal_set_alternate_screen_scroll
Consider upstreaming vte_terminal_set_alternate_screen_scroll
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
[fixed-0-34][fixed-0-36][needed-next]...
: 518405 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-30 00:08 UTC by Behdad Esfahbod
Modified: 2014-04-22 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support DEC 1007 (1.23 KB, patch)
2013-09-30 19:24 UTC, Egmont Koblinger 		none Details | Review

Description Behdad Esfahbod 2013-09-30 00:08:33 UTC 
Ubuntu adds that function (and possible others?) to vte...  Which means Ubuntu's gnome-terminal doesn't run against upstream vte.  Ughh...  Consider taking that patchset upstream perhaps?
Comment 1 Behdad Esfahbod 2013-09-30 00:29:09 UTC 
Bug 518405 (specially comment 60) is relevant.  Keeping this open still since it's about a workaround for Ubuntu's addition, not what to do about alternate-screen per se.
Comment 2 Christian Persch 2013-09-30 09:00:50 UTC 
We could add it as a no-op symbol just for this use case.
Comment 3 Egmont Koblinger 2013-09-30 13:34:33 UTC 
xterm has the escape sequence as well as the alternateScroll resource. Seems to me that if we want to mimic xterm, we'd need to upstream ubuntu's patch _and_ and support for DEC 1007. IMHO why not? :)
Comment 4 Behdad Esfahbod 2013-09-30 16:37:56 UTC 
Someone has to implement it.  If you are volunteering, I don't see why not!
Comment 5 Egmont Koblinger 2013-09-30 18:13:18 UTC 
Sounds easy to implement. I don't care about this feature at all, I'd just like to get that ubuntu patch that I always have to manually apply out of the way :D
Comment 6 Egmont Koblinger 2013-09-30 19:24:05 UTC 
Created attachment 256131 [details] [review]
Support DEC 1007

Goes on top of the Ubuntu patch:
http://archive.ubuntu.com/ubuntu/pool/main/v/vte3/vte3_0.34.2-0ubuntu2.debian.tar.gz -> debian/patches/93_add_alt_screen_scroll_toggle.patch

I enabled alternate screen scroll by default, to be consistent with earlier behavior of VTE.

Note that I'm not changing the state on terminal reset, just like xterm-297 doesn't change either. IMHO it would make more sense to revert the effect of escape sequences and revert to the last value set by the API call.
Comment 7 Behdad Esfahbod 2013-09-30 19:29:35 UTC 
LGTM.  ChPe, can you please review and commit in whatever branch you feel most comfortable?
Comment 8 Christian Persch 2013-09-30 21:22:27 UTC 
Done on vte-0-34.
Comment 9 Christian Persch 2014-04-22 16:48:28 UTC 
*** Bug 518405 has been marked as a duplicate of this bug. ***