After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709057 - keyboard: Port to GtkGrid
keyboard: Port to GtkGrid
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
git master
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-29 22:59 UTC by Kalev Lember
Modified: 2014-08-15 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Port custom shortcut dialog to GtkGrid (4.36 KB, patch)
2013-09-29 23:00 UTC, Kalev Lember 		committed Details | Review
keyboard: Port typing tab to GtkGrid (14.99 KB, patch)
2013-09-29 23:01 UTC, Kalev Lember 		committed Details | Review
keyboard: Port shortcuts tab to GtkGrid (5.21 KB, patch)
2013-09-29 23:01 UTC, Kalev Lember 		committed Details | Review

Description Kalev Lember 2013-09-29 22:59:13 UTC 
.
Comment 1 Kalev Lember 2013-09-29 23:00:57 UTC 
Created attachment 256043 [details] [review]
keyboard: Port custom shortcut dialog to GtkGrid
Comment 2 Kalev Lember 2013-09-29 23:01:04 UTC 
Created attachment 256044 [details] [review]
keyboard: Port typing tab to GtkGrid
Comment 3 Kalev Lember 2013-09-29 23:01:10 UTC 
Created attachment 256045 [details] [review]
keyboard: Port shortcuts tab to GtkGrid
Comment 5 Bastien Nocera 2013-09-30 06:28:53 UTC 
(In reply to comment #4)
> Before and after screenshots:
> 
> http://kalev.fedorapeople.org/custom_shortcut_dialog_before.png
> http://kalev.fedorapeople.org/custom_shortcut_dialog_after.png
> 
> http://kalev.fedorapeople.org/typing_tab_before.png
> http://kalev.fedorapeople.org/typing_tab_after.png

Delay label is centred instead of right-aligned.

> http://kalev.fedorapeople.org/shortcuts_tab_before.png
> http://kalev.fedorapeople.org/shortcuts_tab_after.png

With the understanding that this will all likely be in vain (the panel needs complete redesign to use GtkListBox), looks fine to commit after branching.
Comment 6 Bastien Nocera 2013-09-30 06:29:29 UTC 
Review of attachment 256043 [details] [review]:

++
Comment 7 Bastien Nocera 2013-09-30 06:30:08 UTC 
Review of attachment 256044 [details] [review]:

++
Comment 8 Bastien Nocera 2013-09-30 06:30:35 UTC 
Review of attachment 256045 [details] [review]:

++
Comment 9 Kalev Lember 2013-09-30 08:52:39 UTC 
(In reply to comment #5)
> > http://kalev.fedorapeople.org/typing_tab_before.png
> > http://kalev.fedorapeople.org/typing_tab_after.png
> 
> Delay label is centred instead of right-aligned.

Which way should it be?

Previously, it was marked as left-aligned, but it never showed up as such because GtkTable didn't respect the xalign child property -- it came out centered instead.

Now, it's still marked as left-aligned and it actually shows up as such because GtkGrid respects the child properties.
Comment 10 Bastien Nocera 2014-08-15 12:45:58 UTC 
Attachment 256043 [details] pushed as 34d145b - keyboard: Port custom shortcut dialog to GtkGrid
Attachment 256044 [details] pushed as c3d2631 - keyboard: Port typing tab to GtkGrid
Attachment 256045 [details] pushed as c5c870a - keyboard: Port shortcuts tab to GtkGrid