After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709007 - Redefining GtkJustification
Redefining GtkJustification
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: Graphing / Charting
GIT
Other All
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-09-28 20:57 UTC by Morten Welinder
Modified: 2013-10-01 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (12.61 KB, patch)
2013-09-30 14:29 UTC, Jean Bréfort 		none Details | Review

Description Morten Welinder 2013-09-28 20:57:42 UTC 
goffice/graph/gog-renderer.h seems to redefine GtkJustification when
goffice is compiled without gtk+.

That's not good in a header.

With this, the header cannot be used in a program that uses gtk+ itself.
Comment 1 Jean Bréfort 2013-09-29 06:48:57 UTC 
The easy fix is to replace with GoJustification or so, but this would be an API break.
Comment 2 Jean Bréfort 2013-09-30 14:29:45 UTC 
Created attachment 256089 [details] [review]
Proposed patch
Comment 3 Morten Welinder 2013-09-30 17:35:45 UTC 
Looks good.

I think old code using GTK_... should still work with this patch since
C allows mixing different enums and because the enum values used are the
same.

That means that the old API breaking is that the type of gog_renderer_draw_...
changed in an argument.  It is very unlikely that anyones stores a function
pointer to those anywhere, so go ahead and commit.
Comment 4 Jean Bréfort 2013-10-01 11:58:25 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.