After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708967 - Wi-Fi submenu shows "Turn Off" menu item even when already "Off"
Wi-Fi submenu shows "Turn Off" menu item even when already "Off"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.10.1
Depends on:
Blocks:
 
 
Reported: 2013-09-27 22:15 UTC by Derek Moore
Modified: 2013-11-15 11:42 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10

Attachments
wifi status should show "not connected" when it is powered on ('radio on') but not connected (1.21 KB, text/plain)
2013-10-13 15:36 UTC, Yash Girdhar (irc yash) 		Details

Description Derek Moore 2013-09-27 22:15:06 UTC 
If Wi-Fi status is "Off" the Wi-Fi submenu still shows a "Turn Off" menu item.

This seems to actually control the wifi device's radio on/off state, but this is not apparent, since when the radio is on but not connected to a network the hint text next to the expander arrow says "Off."

What happened to the nice switch button from the old 3.8 menu? Etc.

"Not Connected" and "Radio Off" are different things, UI should clearly distinguish them in UX.
Comment 1 Allan Day 2013-10-01 09:32:28 UTC 
I noticed one of these issues myself.

 * If wi-fi is powered on (radio on, as you've put it) but you aren't connected, the state should read "Not Connected".

 * If wi-fi is powered off, the "Turn Off" item should be replaced with "Turn On"
Comment 2 Allan Day 2013-10-01 09:35:18 UTC 
Bug 709043 covers the "Not Connected" issue. Let's use this one to track the one that's described in the subject.

Derek - it would help if you could try to stick to one issue per bug report. This one could have been split into two.
Comment 3 Yash Girdhar (irc yash) 2013-10-13 15:36:06 UTC 
Created attachment 257174 [details]
wifi status should show "not connected" when it is powered on ('radio on') but not connected

changed js/ui/status/network.js

Link to the bug :
Comment 4 Florian Müllner 2013-10-13 16:02:29 UTC 
Review of attachment 257174 [details]:

What does this fix? The current code should already return "Not connected" if wireless_enabled == true and device_state == DISCONNECTED ...
Comment 5 Florian Müllner 2013-10-13 16:30:23 UTC 
Review of attachment 257174 [details]:

OK, so apparently you are trying to address one of the issues mentioned in this report, but see

(In reply to comment #2)
> Bug 709043 covers the "Not Connected" issue. Let's use this one to track the
> one that's described in the subject.

What you are trying to fix is no longer an issue ...
Comment 6 Florian Müllner 2013-10-13 16:33:51 UTC 
(In reply to comment #1)
>  * If wi-fi is powered off, the "Turn Off" item should be replaced with "Turn
> On"

This is the behavior I see here (and what the shell code was supposed to do since the new network section landed) - libnm issue that got fixed in the meanwhile?
Comment 7 Allan Day 2013-11-15 11:10:39 UTC 
(In reply to comment #6)
> (In reply to comment #1)
> >  * If wi-fi is powered off, the "Turn Off" item should be replaced with "Turn
> > On"
> 
> This is the behavior I see here (and what the shell code was supposed to do
> since the new network section landed) - libnm issue that got fixed in the
> meanwhile?

I don't remember seeing this recently either. Let's assume it's been fixed and reopen otherwise.
Comment 8 Florian Müllner 2013-11-15 11:42:25 UTC 
Yeah, this was fixed in bug 709043.