After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708955 - Port away from libwnck
Port away from libwnck
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-27 21:18 UTC by Armin K.
Modified: 2013-11-21 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
First try (2.40 KB, patch)
2013-09-27 22:23 UTC, Armin K. 		none Details | Review
Second try (1.73 KB, patch)
2013-09-27 22:38 UTC, Armin K. 		accepted-commit_now Details | Review
Third try (1.83 KB, patch)
2013-11-21 13:16 UTC, Armin K. 		committed Details | Review

Description Armin K. 2013-09-27 21:18:57 UTC 
libwnck is X11 specific. For Epiphany to run on Wayland compositors, x11 specific calls need to be wrapped or non X11 equivalents should be used.
Comment 1 Armin K. 2013-09-27 22:23:02 UTC 
Created attachment 255961 [details] [review]
First try
Comment 2 Armin K. 2013-09-27 22:38:33 UTC 
Created attachment 255962 [details] [review]
Second try
Comment 3 Claudio Saavedra 2013-11-21 13:09:50 UTC 
Review of attachment 255962 [details] [review]:

You probably need to add your first comment about the need for this patch in the commit log. Otherwise looks good.
Comment 4 Armin K. 2013-11-21 13:16:30 UTC 
Created attachment 260429 [details] [review]
Third try

Updated patch description as pointed above.