After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708910 - system modals on the lock screen
system modals on the lock screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
3.10.1
Depends on:
Blocks:
 
 
Reported: 2013-09-27 10:50 UTC by Matthias Clasen
Modified: 2013-10-09 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
triple whammy (41.15 KB, image/png)
2013-09-27 10:52 UTC, Matthias Clasen
  Details
keyring: Remove unused global (800 bytes, patch)
2013-09-27 14:13 UTC, Florian Müllner
committed Details | Review
keyring: Cancel active prompts on disable() (1.66 KB, patch)
2013-09-27 14:13 UTC, Florian Müllner
committed Details | Review

Description Matthias Clasen 2013-09-27 10:50:38 UTC
Still happening, with 3.10.0 :-(

The screenshot actually shows 3 bad things happening at the same time:

- spontaneous password dialog
- background loss
- modal on the lock screen
Comment 1 Matthias Clasen 2013-09-27 10:52:03 UTC
Created attachment 255915 [details]
triple whammy
Comment 2 Florian Müllner 2013-09-27 10:55:39 UTC
(In reply to comment #0)
> - modal on the lock screen

That is not a bug by itself, e.g. some system modals are expected to work on the lock screen (namely the polkit dialog when shutting down/rebooting needs confirmation as other users are logged in)
Comment 3 Matthias Clasen 2013-09-27 12:37:30 UTC
(In reply to comment #2)
 
> That is not a bug by itself, e.g. some system modals are expected to work on
> the lock screen (namely the polkit dialog when shutting down/rebooting needs
> confirmation as other users are logged in)

But entering an online account password on the lock screen is unexpected, right ?
Comment 4 Florian Müllner 2013-09-27 12:42:55 UTC
> But entering an online account password on the lock screen is unexpected, right?

Yes. I'll try to reproduce  this in a bit ...
Comment 5 Debarshi Ray 2013-09-27 13:37:13 UTC
Could be a duplicate of bug 708730
Comment 6 Florian Müllner 2013-09-27 14:13:40 UTC
Created attachment 255934 [details] [review]
keyring: Remove unused global
Comment 7 Florian Müllner 2013-09-27 14:13:44 UTC
Created attachment 255935 [details] [review]
keyring: Cancel active prompts on disable()

Since commit 1242a16265d5bf2, we will use a fake prompt which
cancels alls requests without dialog when the keyring component
is disabled. However this does only apply to new requests, dialogs
that are already active when the session mode changes are kept
open. This is not quite as expected, so cancel the prompt in that
case.
Comment 8 Florian Müllner 2013-09-27 14:16:45 UTC
I haven't been able to reproduce keyring dialogs popping up while the screen was already locked, but we are not closing dialogs that are already open - Matthias said he didn't pay very close attention, so maybe that's the issue at hand. In any case, closing any open dialogs when disabling the keyring component sounds like the correct behavior to me anyway ...
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-10-09 15:33:00 UTC
Review of attachment 255934 [details] [review]:

OK.
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-10-09 15:33:05 UTC
Review of attachment 255935 [details] [review]:

OK.
Comment 11 Florian Müllner 2013-10-09 15:59:22 UTC
Attachment 255934 [details] pushed as 3d28836 - keyring: Remove unused global
Attachment 255935 [details] pushed as 627f3ef - keyring: Cancel active prompts on disable()