GNOME Bugzilla – Bug 708862
Wrong message when starting epiphany with disable-fullscreen=true
Last modified: 2014-02-10 08:50:55 UTC
When launching epiphany with "org.gnome.Epiphany.lockdown.disable-fullscreen" set to true the browser runs in permanent fullscreen mode, but the message "Press F11 to exit fullscreen" it's always displayed on startup, which is an action that is not doable.
Created attachment 255867 [details] [review] [PATCH] Avoid showing inaccurate message when lockdown.disable-fullscreen is set
Review of attachment 255867 [details] [review]: The commit message is not good. Instead of "Fixes the bug." you should summarize what you wrote in the bug description. ::: src/ephy-window.c @@ +848,3 @@ sync_chromes_visibility (window); + if (!g_settings_get_boolean (EPHY_SETTINGS_LOCKDOWN, EPHY_PREFS_LOCKDOWN_FULLSCREEN)) { + ephy_embed_entering_fullscreen (embed); I'd say this doesn't make very clear on why we don't call this method when the fullscreen is locked-down. I'd rather check the setting inside the ephy_embed-entering_fullscreen() method, where it's more clear why we are doing this (because the message makes no sense if the fullscreen is locked down).
Created attachment 267963 [details] [review] Avoid showing inaccurate message when lockdown.disable-fullscreen is set Thanks for the comments. I've done the suggested modification and updated the commit description.
Review of attachment 267963 [details] [review]: Thanks!
Comment on attachment 267963 [details] [review] Avoid showing inaccurate message when lockdown.disable-fullscreen is set Pushed to git master, thanks!