Created attachment 255851 [details] [review]
appDisplay: Add hover/active states to indicators

Until now we had the same svg for hover, active and checked
states in the pagination indicators. Just differentiate between
them using differents svg.

Review of attachment 255851 [details] [review]:

Looks good to me. Needs UI freeze for 3.10, or just wait until we branch.

Review of attachment 255851 [details] [review]:

::: data/Makefile.am
@@ +49,3 @@
 	theme/page-indicator-inactive.svg	\
+	theme/page-indicator-checked.svg	\
+	theme/page-indicator-hover.svg	\

argh, I hate it is using tabs so my editor don't show them correctly....fixed in next patch using gedit to make sure of that

Created attachment 255853 [details] [review]
appDisplay: Add hover/active states to indicators

Until now we had the same svg for hover, active and checked
states in the pagination indicators. Just differentiate between
them using differents svg.

Created attachment 255857 [details] [review]
appDisplay: Add hover/active states to indicators

Until now we had the same svg for hover, active and checked
states in the pagination indicators. Just differentiate between
them using differents svg.

Comment on attachment 255857 [details] [review]
appDisplay: Add hover/active states to indicators

Following Florian comment to let active state win over checked state

Review of attachment 255857 [details] [review]:

::: data/theme/gnome-shell.css
@@ +963,3 @@
+}
+
+.page-indicator:checked:active .page-indicator-icon {

You should combine this as
    .page-indicator:active .page-indicator-icon,
    .page-indicator:active:checked .page-indicator-icon
instead of using identical but separate styles

Created attachment 255858 [details] [review]
appDisplay: Add hover/active states to indicators

Until now we had the same svg for hover, active and checked
states in the pagination indicators. Just differentiate between
them using differents svg.

Comment on attachment 255858 [details] [review]
appDisplay: Add hover/active states to indicators

Ok Florian. Applied your comment.

Created attachment 255932 [details] [review]
theme: Add hover/active states to indicators

Until now we had the same svg for hover, active and checked
states in the pagination indicators. Just differentiate between
them using differents svg.

svg files provided by Jakub Steiner

Attachment 255932 [details] pushed as 465af55 - theme: Add hover/active states to indicators