After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708832 - Control center crashes on cancel sing in dialog for account with expired credentials
Control center crashes on cancel sing in dialog for account with expired cred...
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-26 11:49 UTC by Anton Sudak
Modified: 2013-09-27 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
oauth2: Propagate the error if the dialog is dismissed during refresh (860 bytes, patch)
2013-09-27 13:07 UTC, Debarshi Ray 		committed Details | Review

Description Anton Sudak 2013-09-26 11:49:21 UTC 
Control center crashed when I cancel sign in dialog for Google account with expired credentials.
Comment 1 Debarshi Ray 2013-09-27 12:17:57 UTC 
A regression in 3.9/3.10. Worked as expected in 3.8.x.
Comment 2 Debarshi Ray 2013-09-27 13:05:25 UTC 
This is a fallout from this commit:

commit a6ce50a8ab89242d7d25611c3828033e854a263d
Author: Emanuele Aina <emanuele.aina@collabora.com>
Date:   Tue Apr 23 16:42:01 2013 +0200

    oauth2: Internally use private data fields instead of out parameters
    
    https://bugzilla.gnome.org/show_bug.cgi?id=695118
Comment 3 Debarshi Ray 2013-09-27 13:06:02 UTC 
Reassigning to gnome-online-accounts.
Comment 4 Debarshi Ray 2013-09-27 13:07:41 UTC 
Created attachment 255929 [details] [review]
oauth2: Propagate the error if the dialog is dismissed during refresh
Comment 5 Debarshi Ray 2013-09-27 13:10:16 UTC 
Comment on attachment 255929 [details] [review]
oauth2: Propagate the error if the dialog is dismissed during refresh

Pushed to both master and gnome-3-10.