GNOME Bugzilla – Bug 708796
Bonobo and ORBit deprecation/removal
Last modified: 2013-11-02 16:04:56 UTC
As per [1], Bonobo and ORBit were deprecated and removed from GNOME years ago. I don't believe MouseTrap actually uses either anymore, but from a quick grep it seems there is Bonobo and ORBit cruft hanging around: $ grep -riE "(orbit|bonobo)" acinclude.m4:dnl AM_CHECK_PYORBIT_MOD(MODNAME [,ACTION-IF-FOUND [,ACTION-IF-NOT-FOUND]]]) acinclude.m4:dnl Check if a module containing a given ORBit module is visible to python. acinclude.m4:AC_DEFUN([AM_CHECK_PYORBIT_MOD], acinclude.m4:AC_MSG_CHECKING(for PyORBit module $1) acinclude.m4: import bonobo acinclude.m4: import ORBit acinclude.m4: ORBit.load_typelib(\"$1\") src/mousetrap/app/mousetrap.in: # because of something going on in pyorbit. This should be src/mousetrap/app/mousetrap.in: # fixed in pyorbit 2.14.1, but not everyone has that. [1] https://developer.gnome.org/platform-overview/2.32/bonobo-corba.html
Created attachment 257050 [details] [review] Remove cruft patch Removes orbit and bonobo cruft
Review of attachment 257050 [details] [review]: Breaks autogen.sh. Try the following before and after applying the patch. $ git clean -Xfd $ ./autogen.sh 2> errors.txt ... After the patch, errors.txt contains the following: : error: invalid feature name: maintainer-mode ./configure: line 406: as_fn_exit: command not found ./configure: line 1524: as_fn_set_status: command not found ./configure: line 1524: as_fn_set_status: command not found ... I think you deleted half of AM_CHECK_PYORBIT_MOD. It goes from 63-98. Please use `git format-patch` to create patches.
Created attachment 257561 [details] [review] Remove cruft patch This patch removes Orbit and Bonobo cruft from the install check. The patch has been tested and is formatted using git format-patch.
Review of attachment 257561 [details] [review]: Looks good. Nice work, and thanks!
Review of attachment 257561 [details] [review]: I should have stated in my last review: I have applied and tested this patch. I think it's good.
Script removes Bonobo and ORBit cruf https://git.gnome.org/browse/mousetrap/commit/?h=gnome3-wip&id=b15240a6e9277f5b7d8e6839bee72cb70543c189