After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708778 - pango_attr_iterator_get_font(): handle scaling absolute font sizes
pango_attr_iterator_get_font(): handle scaling absolute font sizes
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks: 708780
 
 
Reported: 2013-09-25 18:52 UTC by Owen Taylor
Modified: 2013-09-25 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pango_attr_iterator_get_font(): handle scaling absolute font sizes (1.18 KB, patch)
2013-09-25 18:52 UTC, Owen Taylor 		committed Details | Review
Test case showing the original bug (1.27 KB, text/x-csrc)
2013-09-25 18:56 UTC, Carl Worth 		  Details

Description Owen Taylor 2013-09-25 18:52:21 UTC 
Here's a patch for a bug that cworth noticed - I haven't even tested
for compilation, however.
Comment 1 Owen Taylor 2013-09-25 18:52:23 UTC 
Created attachment 255714 [details] [review]
pango_attr_iterator_get_font(): handle scaling absolute font sizes

When handling PANGO_ATTR_SCALE on a font description with an absolute
size, properly preserve the absolute flag when setting the scaled
size.
Comment 2 Carl Worth 2013-09-25 18:56:46 UTC 
Created attachment 255715 [details]
Test case showing the original bug

This is the test case that inspired Owen's patch.

Before his patch, the text within the <small> tag actually ends up larger than the text outside the small tag.

Hopefully, this is fixed after the patch is applied, (but I haven't tested that myself yet).

-Carl
Comment 3 Owen Taylor 2013-09-25 21:29:37 UTC 
Pushed - I did test at least for compilation

Attachment 255714 [details] pushed as bb5c4c8 - pango_attr_iterator_get_font(): handle scaling absolute font sizes