GNOME Bugzilla – Bug 708760
Please include an AppData file
Last modified: 2015-10-16 20:41:14 UTC
Created attachment 255699 [details] [review] patch that works for me Nemiver has no AppData file and looks bad in GNOME Software, the new software center for GNOME 3.10. I've attached something that works for me. You'll have to add the contact details and check the description for me. Thanks.
Comment on attachment 255699 [details] [review] patch that works for me <screenshot type="default">https://projects.gnome.org/evince/images/screenshot-full.png</screenshot> That one's totally outdated, evince doesn't look like that any more! (We should probably remove the projects.g.o/evince website completely.)
+ <licence>CC0</licence> Also, the file lacks a copyright comment and licence header in an xml comment. Plus, I don't think we want anything CC0 in evince; should be GPL2+ instead.
If you make it GPL, it won't be used: http://people.freedesktop.org/~hughsient/appdata/#licence
I don't see anything in that document that would exclude the GPL. It merely says "Permissible licence codes include: " [the CC licences] and links to fedora, which under https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Content_Licenses in note A that the GPL is ok to use.
Christian, could you please provide a properly screenshot to use in the appdata file? Also, the patch needs work. The @INTLTOOL_XML_NOMERGE_RULE@ directive must be changed to @INTLTOOL_XML_RULE@ Thanks!
I've added a rudimentary appdata file in git master; please feel free to improve upon it. I didn't add a screenshot. If we are to have one, I think contrary to what the patch in bug 731708 does, it shouldn't be added specially for the appdata, but be one that is included in our help (and thus more likely to be kept up-to-date) and just linked from there.
Description is ok for me, but if module's maintainers want to change it, it's also ok. About the screenshot, it's a good idea to link it with one included in the userguide, but I don't see any appropiate image but this one: https://git.gnome.org/browse/evince/plain/help/C/figures/annotations-nav-to-page.png Also, the appdata file should be moved to the data folder, to keep consistency with other modules. Thanks!
Should we close this now then?
(In reply to comment #8) > Should we close this now then? I'd rather have a valid screenshot before closing the bug. If the image I've proposed above is ok, feel free to commit the change, or let me know and I'll commit it for you. Thanks!
No, please, don't use a screenshot with the so ugly annotations UI :-P We should use a current screenshot showing the new UI and with current adwaita I think.
Hahaha ok, we won't use that image. Could you please provide us an up-to-date screenshot? Thanks!
did this land ?
Yes, although we need a tarball release before it's usable.
Closing as fixed as per last comment.