After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708749 - util: improve logging of unrecognized GErrors
util: improve logging of unrecognized GErrors
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-25 13:41 UTC by Giovanni Campagna
Modified: 2013-09-25 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
util: improve logging of unrecognized GErrors (4.91 KB, patch)
2013-09-25 13:41 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-09-25 13:41:19 UTC 
If a GError is not from a known domain, it will be marshalled as
a regular boxed type, and thus will not have the special toString()
that logError() relies on for type and message.
Recognize that case and extract the information from the GError
structure directly.
Comment 1 Giovanni Campagna 2013-09-25 13:41:22 UTC 
Created attachment 255686 [details] [review]
util: improve logging of unrecognized GErrors
Comment 2 Colin Walters 2013-09-25 13:50:48 UTC 
Review of attachment 255686 [details] [review]:

Future generations will construct a shrine in your honor for this patch.
Comment 3 Giovanni Campagna 2013-09-25 13:55:44 UTC 
Attachment 255686 [details] pushed as 61acb49 - util: improve logging of unrecognized GErrors