GNOME Bugzilla – Bug 708655
App menu "Folders" option does not function as expected
Last modified: 2013-12-10 16:41:42 UTC
On the application menu, the "Folders" option unexpectedly toggles the sidebar. This seems unexpected, though I'm not sure what one could expect to happen after clicking a "Folders" menu item. Is it supposed to be named "Show Sidebar" instead of "Folders?" The sensitivity of the option with respect to the List Mode setting also does not seem right. E.g. with List Mode set to "View as a folder," toggle "Folders" on to display the sidebar, then change List Mode to "View All Files." "Folders" becomes insensitive and the sidebar unexpectedly disappears (though the toggle is still confusingly turned on).
(In reply to comment #0) > On the application menu, the "Folders" option unexpectedly toggles the sidebar. > This seems unexpected, though I'm not sure what one could expect to happen > after clicking a "Folders" menu item. Is it supposed to be named "Show > Sidebar" instead of "Folders?" But the sidebar only contains the folders list so it was named Folders, maybe "Show Folders" is better. > > The sensitivity of the option with respect to the List Mode setting also does > not seem right. E.g. with List Mode set to "View as a folder," toggle > "Folders" on to display the sidebar, then change List Mode to "View All Files." > "Folders" becomes insensitive and the sidebar unexpectedly disappears (though > the toggle is still confusingly turned on). It disappears because when viewing all the files selecting a single folder makes no sense.
(In reply to comment #1) > But the sidebar only contains the folders list so it was named Folders Oh, I see.... > maybe "Show Folders" is better. Well I don't think so; semantically, "Noun On/Off" (what it is now) makes more sense than "Verb (Object) On/Off" and its obvious that turning off folders means not showing folders. Not really a big deal either way, though. The problem is that if folders are turned off, I would not expect to see any folders outside the sidebar, but I do, which is confusing. And I certainly don't expect that an option simply named "Folders" controls the display of the sidebar. I think if the option was renamed to "Sidebar" (or "Folder Tree" or something) instead of "Folders," there wouldn't be any confusion. > It disappears because when viewing all the files selecting a single folder > makes no sense. I see, that's right.
(In reply to comment #2) > The problem is that if folders are turned off, I would not expect to see any > folders outside the sidebar, but I do, which is confusing. And I certainly > don't expect that an option simply named "Folders" controls the display of the > sidebar. I think if the option was renamed to "Sidebar" (or "Folder Tree" or > something) instead of "Folders," there wouldn't be any confusion. Ok, I'm fine with "Sidebar"
Created attachment 263883 [details] [review] App menu: rename Folders to Sidebar Sorry for the delay. I just renamed the menu item; I did not update the code itself (the action name is still view-folders, the enum value remains PREF_UI_VIEW_FOLDERS). It might be more clear to do so - do you want that done as well?
(In reply to comment #4) > Created an attachment (id=263883) [details] [review] > App menu: rename Folders to Sidebar > > Sorry for the delay. I just renamed the menu item; I did not update the code > itself (the action name is still view-folders, the enum value remains > PREF_UI_VIEW_FOLDERS). It might be more clear to do so - do you want that done > as well? I did it for you :)
(In reply to comment #5) > I did it for you :) Much appreciated, I've been poking around in too many projects lately....