After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708616 - Theme previews are not displayed
Theme previews are not displayed
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Preferences
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-23 12:09 UTC by Frederic Peters
Modified: 2013-09-24 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theme-adium: still execute the start of the script if ressource is missing (1.43 KB, patch)
2013-09-24 14:39 UTC, Guillaume Desmottes 		committed Details | Review

Description Frederic Peters 2013-09-23 12:09:05 UTC 
For most themes I do not get any preview in the Preferences dialog; for a few of them the background changes (when it is set to an image, noteboard, pushpin, pushpin vintage, etc.).  This is empathy from git and WebKit 2.1.92.
Comment 1 Guillaume Desmottes 2013-09-24 13:20:39 UTC 
I can reproduce. Reverting c2e916b doesn't help so it's more likely a WebKit issue.
Comment 2 Guillaume Desmottes 2013-09-24 14:37:22 UTC 
Actually it's because of https://git.gnome.org/browse/empathy/commit/?id=19e784a4b2655db5cf414c7ce43662a9adb9d0c6  (thanks git bisect!). Fix on the way.
Comment 3 Guillaume Desmottes 2013-09-24 14:39:40 UTC 
Created attachment 255635 [details] [review]
theme-adium: still execute the start of the script if ressource is missing

This fix a regression introduced by 19e784a4b2655db5cf414c7ce43662a9adb9d0c6.

If empathy-chat.js can't be find (like in the preferences dialog) we still
want to execute the start of the script.
Comment 4 Xavier Claessens 2013-09-24 14:42:20 UTC 
+1
Comment 5 Guillaume Desmottes 2013-09-24 15:07:27 UTC 
Attachment 255635 [details] pushed as b205d66 - theme-adium: still execute the start of the script if ressource is missing