After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708590 - adder: Should send its segment before checking for eos
adder: Should send its segment before checking for eos
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-22 21:04 UTC by Mathieu Duponchelle
Modified: 2013-09-24 08:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Sends pending segment before checking for eos. (4.02 KB, patch)
2013-09-22 21:04 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2013-09-22 21:04:36 UTC 
Created attachment 255537 [details] [review]
Sends pending segment before checking for eos.

In gnonlin, after building and then seeking the new pipeline and its elements, we discard all EOS before getting a new segment, this prevents situations where we would get EOS from previous segments.

Videomixer for instance sends its new segment in collected *before* checking for EOS.

Adder on the other hand checked in the opposite order, and thus could send EOS without pushing the segment it applies to. This meant gnonlin would ignore the EOS, and then not rebuild the next pipeline.

The patch attached corrects that.
Comment 1 Olivier Crête 2013-09-23 19:46:00 UTC 
Review of attachment 255537 [details] [review]:

Looks fine to me, ok for 1.2?
Comment 2 Sebastian Dröge (slomo) 2013-09-24 08:19:34 UTC 
commit 663f71a5ddfcf75adbc857fb1c275f82e6e5dbe9
Author: Mathieu Duponchelle <mathieu.duponchelle@epitech.eu>
Date:   Sun Sep 22 22:55:33 2013 +0200

    adder: send pending segment out before checking for EOS
    
    Otherwise there would be cases where it would not send its segment
    out when the first collected after getting it would already yield EOS.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708590