GNOME Bugzilla – Bug 708590
adder: Should send its segment before checking for eos
Last modified: 2013-09-24 08:20:07 UTC
Created attachment 255537 [details] [review]
Sends pending segment before checking for eos.
In gnonlin, after building and then seeking the new pipeline and its elements, we discard all EOS before getting a new segment, this prevents situations where we would get EOS from previous segments.
Videomixer for instance sends its new segment in collected *before* checking for EOS.
Adder on the other hand checked in the opposite order, and thus could send EOS without pushing the segment it applies to. This meant gnonlin would ignore the EOS, and then not rebuild the next pipeline.
The patch attached corrects that.
Review of attachment 255537 [details] [review]:
Looks fine to me, ok for 1.2?
Author: Mathieu Duponchelle <firstname.lastname@example.org>
Date: Sun Sep 22 22:55:33 2013 +0200
adder: send pending segment out before checking for EOS
Otherwise there would be cases where it would not send its segment
out when the first collected after getting it would already yield EOS.