GNOME Bugzilla – Bug 708577
Automatically create archives when needed
Last modified: 2018-08-03 20:05:05 UTC
Project page: https://wiki.gnome.org/SummerOfCode2013/Projects/TingWeiLan_GnomeArchives Epiphany will create archives when it is required. It can create an archive for each directory before uploading. It can also create an archive for all selected files and directories, so you can upload multiple files and directories even the <input> button only allow single file. Archive progress is reported using the status message bar on the buttom of the page, and it is cancellable via right click on the web page.
Created attachment 255517 [details] [review] [1/4] Automatically create archives if required when select files to upload embed/ephy-web-view.c | 443 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 443 insertions(+)
Created attachment 255518 [details] [review] [2/4] Generate suggested archive name from selected files and archive format embed/ephy-web-view.c | 121 +++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 120 insertions(+), 1 deletion(-)
Created attachment 255519 [details] [review] [3/4] Archive creating can be cancelled embed/ephy-web-view.c | 89 ++++++++++++++++++++++++++++++++++++++----- embed/ephy-web-view.h | 2 + src/ephy-window.c | 4 ++ src/resources/epiphany-ui.xml | 1 + src/window-commands.c | 15 ++++++++ src/window-commands.h | 2 + 6 files changed, 103 insertions(+), 10 deletions(-)
Created attachment 255520 [details] [review] [4/4] Show "Stop Archiving" only when the EphyWebView is archiving embed/ephy-web-view.c | 2 +- src/ephy-window.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-)
The updated page is here: https://wiki.gnome.org/Outreach/SummerOfCode/2013/Projects/TingWeiLan_GnomeArchives
Created attachment 285027 [details] [review] New patch file which works with current master branch
Created attachment 286108 [details] [review] Updated patch which works with the current master branch No code is modified. Only line numbers are corrected.
Review of attachment 286108 [details] [review]: Again, sorry for the huge delay in reviewing this. I'm just going to give this a cursory review, since you have another patch in bug #705599 to work on still. The issues I mention at the top of that review apply here too; most importantly, I want to see explicit approval from a designer, since I'm not sure they were involved in this process, unfortunately. ::: embed/ephy-web-view.c @@ +2096,3 @@ } +#define EPHY_RESPONSE_SELECT 1 I don't think EphyWebView is a good place for any of the file chooser code. This class is for managing the web view itself, whereas the file chooser is really a completely separate widget. Most of this code should be integrated into EphyFileChooser. The file chooser itself should probably be spawned in EphyWindow, I think. You can connect to run-file-chooser from there. ::: src/ephy-window.c @@ +1806,3 @@ + if (ephy_web_view_get_is_archiving (EPHY_WEB_VIEW (web_view))) + add_action_to_context_menu (context_menu, + priv->action_group, "ViewStopArchiving"); I really don't think this context menu item is needed. Nobody is ever going to find it. There should be a more obvious way to cancel archiving.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/207.