After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708573 - function markers are too dark
function markers are too dark
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
1.12.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-09-22 12:56 UTC by Adam Dingle
Modified: 2013-09-25 23:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Adam Dingle 2013-09-22 12:56:06 UTC
I'm using Gnumeric 1.12.6.

I like Gnumeric's function markers feature, which displays an indicator in each cell which has a computed value.  But I think function markers are too dark: the dark green color makes it hard to read numbers underneath.  I think the color should be lightened.
Comment 1 Andreas J. Guelzow 2013-09-22 17:39:15 UTC
dark green? The color used is light green.
Comment 2 Morten Welinder 2013-09-22 20:38:13 UTC
It's "green", i.e., #ffff00.

/* Function markers are enabled from View->View Properties->Cell Markers */
GnmItemGrid function-marker {
  color: green;
  border-color: #555555;
  /* See also GnmPane */
}

I never use this myself, so I don't care much.  Any suggestion as to what
colour fits better?  Use ~/.config/gtk-3.0/gtk.css for testing.
Comment 3 Morten Welinder 2013-09-24 17:11:42 UTC
Anyone against this?

GnmItemGrid function-marker {
  color: #80ff80;
}
Comment 4 Adam Dingle 2013-09-25 10:42:44 UTC
Actually I think it would be nicer to choose one of the colors from GNOME's palette:

https://developer.gnome.org/hig-book/3.10/design-color.html.en

I think any of the Hilight colors (green, red, purple, blue) would work fine.  I might lean slightly toward blue (#9DB8D2) since it looks similar to the color of the arrow toolbar button which enters a calculation, in the default Adwaita theme at least.  But, again, any of these could work.
Comment 5 Morten Welinder 2013-09-25 19:17:37 UTC
None of the green choices seem to work any better than plain green.
Most are about as dark as plain green.  Hilight Green isn't really green:
it's gray.

I am not sure how much LSD went into that process.

So #80ff80 it is.


This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 6 Andreas J. Guelzow 2013-09-25 21:29:31 UTC
I don't think it is necessarily the fill colour that is interfering but the border. I think

/* Function markers are enabled from View->View Properties->Cell Markers */
GnmItemGrid function-marker {
  color: #80ff80;;
  border-color: #80ff80;
  /* See also GnmPane */
}

would in fact work better.
Comment 7 Adam Dingle 2013-09-25 23:24:03 UTC
I agree that the border is much of the problem.  I think a faint gray border would be better than none, e.g.

GnmItemGrid function-marker {
  color: #80ff80;
  border-color: #70a070;
}