After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708546 - Critical warning from touchpad "tap-to-click" setting handler
Critical warning from touchpad "tap-to-click" setting handler
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: mouse
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-21 18:14 UTC by Kalev Lember
Modified: 2013-09-23 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mouse: Fix critical warnings with touchpad settings (1.54 KB, patch)
2013-09-21 18:20 UTC, Kalev Lember 		committed Details | Review

Description Kalev Lember 2013-09-21 18:14:35 UTC 
I was running g-s-d in the debugger to catch criticals from geocode-glib, but ran into one from the mouse plugin instead:

mouse-plugin-DEBUG: setting handedness on Logitech USB-PS/2 Optical Mouse
mouse-plugin-DEBUG: setting motion on Logitech USB-PS/2 Optical Mouse
mouse-plugin-DEBUG: Setting accel 1/1, threshold 10 for device 'Logitech USB-PS/2 Optical Mouse'
mouse-plugin-DEBUG: setting motion on Logitech USB-PS/2 Optical Mouse
mouse-plugin-DEBUG: Setting accel 1/1, threshold 10 for device 'Logitech USB-PS/2 Optical Mouse'

GLib-CRITICAL **: g_variant_get_boolean: assertion 'g_variant_is_of_type (value, G_VARIANT_TYPE_BOOLEAN)' failed

Program received signal SIGTRAP, Trace/breakpoint trap.

(gdb) bt

+ Trace 232519

  • #0 g_logv
    at gmessages.c line 989
  • #1 g_log
    at gmessages.c line 1025
  • #2 g_return_if_fail_warning
  • #3 g_variant_get_boolean
    at gvariant.c line 369
  • #4 g_settings_get_boolean
    at gsettings.c line 1781
  • #5 touchpad_callback
    at gsd-mouse-manager.c line 1059 

...
Comment 1 Kalev Lember 2013-09-21 18:20:17 UTC 
Created attachment 255496 [details] [review]
mouse: Fix critical warnings with touchpad settings

The code was handling touchpad "left-handed" key as a boolean, but it's
an enum.
Comment 2 Rui Matos 2013-09-21 18:34:09 UTC 
Review of attachment 255496 [details] [review]:

Looks good
Comment 3 Bastien Nocera 2013-09-23 01:02:39 UTC 
Can you please request a freeze break for this? That might also be applicable to gnome-3-8.
Comment 4 Kalev Lember 2013-09-23 12:22:59 UTC 
Freeze break approval:
https://mail.gnome.org/archives/release-team/2013-September/msg00192.html

Attachment 255496 [details] pushed as e52d2c2 - mouse: Fix critical warnings with touchpad settings