After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708545 - opencv: new plugin to make smooth slowmotion
opencv: new plugin to make smooth slowmotion
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 699077
Blocks:
 
 
Reported: 2013-09-21 17:39 UTC by Mathieu Duponchelle
Modified: 2018-11-03 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
That code builds and yields interesting results already, major work needed. (88.27 KB, patch)
2014-02-27 21:20 UTC, Mathieu Duponchelle
none Details | Review

Description Mathieu Duponchelle 2013-09-21 17:39:52 UTC
The plugin uses code from slowmovideo, porting it from QT and its own internal decoding "framework" based on ffmpeg to gstreamer.

the code is available there :
https://github.com/MathieuDuponchelle/gst-plugins-base/commits/slowmotion

and is up for trial / review, one issue I am aware of and will fix is the fact that it should be in bad/ext/opencv.

example launch line:

gst-launch-1.0 -e uridecodebin uri=file:///any/file ! videoconvert ! videorate rate=0.1 ! video/x-raw, format=RGB ! slowmo ! videoconvert ! theoraenc ! oggmux ! filesink location=somewhere.ogv

The videoconversion is necessary, as the code will only accept either RGB or BGR for now.

The videorate is also necessary, with a patch from that comment:

https://bugzilla.gnome.org/show_bug.cgi?id=699077#c25

Please do the review here, as github throws away commit comments when pushing non fast forward.

There's plenty of room for optimization and cleanup, contributions are more than welcome :)
Comment 1 Sebastian Dröge (slomo) 2013-09-28 11:03:52 UTC
Could you squash all these commits together and attach it here as a patch? That makes reviewing easier, just use git-bz.
Comment 2 Mathieu Duponchelle 2013-10-06 19:28:24 UTC
Just realizing you commented, I should check my emails more thoroughly. Yes I can do that.
Comment 3 Tobias Wolf 2013-10-26 09:15:44 UTC
What does it do with videorate rate > 1?

Can I make a timelapse that merges frames or averages over frames?
Comment 4 Mathieu Duponchelle 2014-02-27 21:19:22 UTC
Tobias, it just won't do anything as no buffer will be marked as a GAP buffer by videorate. A timelapse that would average frames would need a different design in my opinion, as you can't put the plugin downstream of videorate.

Attaching the sources as a patch. I must warn you the code is very rough, major cleaning will need to be done, and I still have to put that in -bad and not -base.

I think reviewing what's existing nevertheless is interesting for people who would like to take on the job, or for future, spare-time rich me.
Comment 5 Mathieu Duponchelle 2014-02-27 21:20:44 UTC
Created attachment 270510 [details] [review]
That code builds and yields interesting results already, major work needed.
Comment 6 Antonio Ospite 2016-01-12 14:17:36 UTC
Hi Mathieu, this is interesting.

I tried asking the slowmoVideo devs if they are interested in exposing a core API to use with GUI/media frameworks other than Qt/ffmpeg, here is my issue on their github repo:

https://github.com/slowmoVideo/slowmoVideo/issues/57

If you have any comment please chip in.

Ciao ciao,
   Antonio
Comment 7 Luis de Bethencourt 2016-01-12 15:34:22 UTC
This looks very promising.

Nice to see the list of elements in gst-plugins-bad/ext/opencv/ growing :)
Comment 8 Mathieu Duponchelle 2016-01-12 17:23:05 UTC
(In reply to Antonio Ospite from comment #6)
> Hi Mathieu, this is interesting.
> 
> I tried asking the slowmoVideo devs if they are interested in exposing a
> core API to use with GUI/media frameworks other than Qt/ffmpeg, here is my
> issue on their github repo:
> 
> https://github.com/slowmoVideo/slowmoVideo/issues/57
> 
> If you have any comment please chip in.
> 
> Ciao ciao,
>    Antonio

Done, not much to say though it's been quite some time now!
Comment 9 GStreamer system administrator 2018-11-03 13:17:49 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/109.