After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708524 - Move tab in context menu have needless options
Move tab in context menu have needless options
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Tabs
3.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-21 11:00 UTC by medeoTL
Modified: 2014-09-11 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.32 KB, patch)
2014-05-02 10:26 UTC, Robert Roth 		committed Details | Review

Description medeoTL 2013-09-21 11:00:11 UTC 
First tab have in his contextual menu the "move tab left" option, wich obviously do nothing. Same for as regard the last tab and the related "move tab right" option
Comment 1 Robert Roth 2014-05-02 10:10:12 UTC 
gEdit only grays the unavailable option, as that's what the HIG suggests to do, so epiphany should also disable move left/right in case of the first/last tab.
Comment 2 Robert Roth 2014-05-02 10:26:08 UTC 
Created attachment 275628 [details] [review]
Proposed patch

Disable move to left tab popup action for the first tab and disable move to right tab popup action for the last tab.
Comment 3 Michael Catanzaro 2014-08-17 15:47:58 UTC 
Review of attachment 275628 [details] [review]:

Looks good.
Comment 4 Michael Catanzaro 2014-09-11 03:46:16 UTC 
Thanks!
Comment 5 Robert Roth 2014-09-11 05:26:08 UTC 
Wow, this was a long time ago. I guess this shouldn't get in right now, only in the next cycle, as we're past UI and String freeze. As the patch is in accepted commit now state, and I can't find it in gedit log, I guess this should be reopened, as it's far from fixed.
Comment 6 Michael Catanzaro 2014-09-11 13:09:24 UTC 
Comment on attachment 275628 [details] [review]
Proposed patch

This is Epiphany. :)  Your patch doesn't add any strings, it just disables context menu entries when they would otherwise be broken.

git-bz failed to change the patch state for some reason when I pushed it yesterday.

I wanted your cookies dialog search patch too, but that's clearly not going to happen this cycle. :(