After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708511 - tests: Fix U-Boot test case
tests: Fix U-Boot test case
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-21 01:52 UTC by Javier Martinez Canillas
Modified: 2013-09-21 19:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH 1/1] tests: Fix U-Boot test case (7.51 KB, patch)
2013-09-21 01:53 UTC, Javier Martinez Canillas 		committed Details | Review

Description Javier Martinez Canillas 2013-09-21 01:52:08 UTC 
commit 08b873457 ("deploy: Remove checksum from generated loader entries")
changed the generated loader entries file names thus making the U-Boot test
case to fail since this test parsed those files.

Fix test-admin-deploy-uboot.sh by looking to the updated files names.
Comment 1 Javier Martinez Canillas 2013-09-21 01:53:51 UTC 
Created attachment 255457 [details] [review]
[PATCH 1/1] tests: Fix U-Boot test case
Comment 2 Colin Walters 2013-09-21 14:55:47 UTC 
Review of attachment 255457 [details] [review]:

Oops!  But why is it not failing for me?  Oh...I see, you didn't add it to Makefile-tests.am.  How are you running it?  Just by hand?

I'll commit this and then add it to the overall tests.
Comment 3 Colin Walters 2013-09-21 15:09:17 UTC 
See https://git.gnome.org/browse/ostree/commit/?id=c044cdfb7d11225a120228046ced416ddcaeb4a2

and https://live.gnome.org/GnomeGoals/InstalledTests

I run the tests this way:

$ gnome-desktop-testing-runner -p 0 ostree/

In the installed tests model, you can run any subset or all of the tests for *all* components at any time, the "ostree/" bit on the end says to just run the tests whose name starts with ostree/.
Comment 4 Javier Martinez Canillas 2013-09-21 19:47:26 UTC 
(In reply to comment #2)
> Review of attachment 255457 [details] [review]:
> 
> Oops!  But why is it not failing for me?  Oh...I see, you didn't add it to
> Makefile-tests.am.  How are you running it?  Just by hand?
> 

Yes, I was just running it manually with:

$ ./ostree/tests/test-admin-deploy-uboot.sh

> I'll commit this and then add it to the overall tests.

Thanks a lot for doing this and sorry that I didn't do myself when adding this test case. I didn't know about neither the GNOME tests infrastructure nor the gnome-desktop-testing runner, thanks for the pointer.