After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708477 - lib: Correct error reporting for connect methods
lib: Correct error reporting for connect methods
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2013-09-20 16:59 UTC by Bastien Nocera
Modified: 2013-09-22 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lib: Correct error reporting for connect methods (2.74 KB, patch)
2013-09-20 16:59 UTC, Bastien Nocera 		none Details | Review
lib: Correct error reporting for connect methods (2.83 KB, patch)
2013-09-20 17:47 UTC, Bastien Nocera 		committed Details | Review
lib: Fix double-free when finishing connection (1.08 KB, patch)
2013-09-20 17:48 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-09-20 16:59:12 UTC 
And make sure to handle cancellations correctly.
Comment 1 Bastien Nocera 2013-09-20 16:59:13 UTC 
Created attachment 255424 [details] [review]
lib: Correct error reporting for connect methods
Comment 2 Bastien Nocera 2013-09-20 17:47:57 UTC 
Created attachment 255432 [details] [review]
lib: Correct error reporting for connect methods

And make sure to handle cancellations correctly.
Comment 3 Bastien Nocera 2013-09-20 17:48:20 UTC 
Created attachment 255433 [details] [review]
lib: Fix double-free when finishing connection

The proxy was already unref'ed when we started the
connection/disconnection so the only places that should hold a reference
are the tree model, and the operation itself.

Fixes the bugs reported in:
http://retrace.fedoraproject.org/faf/reports/205937/
Comment 4 Matthias Clasen 2013-09-20 18:00:37 UTC 
Review of attachment 255432 [details] [review]:

looks right to me
Comment 5 Matthias Clasen 2013-09-20 18:01:18 UTC 
Review of attachment 255433 [details] [review]:

looks right
Comment 6 Bastien Nocera 2013-09-22 20:22:09 UTC 
Attachment 255432 [details] pushed as dbcb379 - lib: Correct error reporting for connect methods
Attachment 255433 [details] pushed as 3d77ac7 - lib: Fix double-free when finishing connection