After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708456 - entry appears when clicking Download place in sidebar
entry appears when clicking Download place in sidebar
Status: RESOLVED FIXED
Product: gnome-user-share
Classification: Core
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-user-share maintainers
gnome-user-share maintainers
: 708530 721645 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-20 13:47 UTC by William Jon McCann
Modified: 2014-01-06 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (52.00 KB, image/png)
2013-09-20 13:47 UTC, William Jon McCann 		  Details
trivial: fix logic error (972 bytes, patch)
2013-09-24 21:28 UTC, Dominique Leuenberger 		reviewed Details | Review
Check whether bar is NULL before assigning anything into it (983 bytes, patch)
2013-10-27 16:43 UTC, Mohammad DAMT 		none Details | Review
share-bar: Check whether bar is NULL before using it (1.27 KB, patch)
2013-11-09 13:29 UTC, Bastien Nocera 		committed Details | Review

Description William Jon McCann 2013-09-20 13:47:46 UTC 
Created attachment 255401 [details]
screenshot

When I open the app and click from Home to Downloads in the sidebar a strange entry box appears in the headerbar. Once it is there it doesn't go away.
Comment 1 António Fernandes 2013-09-21 13:08:21 UTC 
*** Bug 708530 has been marked as a duplicate of this bug. ***
Comment 2 Dominique Leuenberger 2013-09-21 13:11:04 UTC 
(In reply to comment #1)
> *** Bug 708530 has been marked as a duplicate of this bug. ***

Note that this bug had some further reaching Stack Traces about 'after effects' of the Location Bar appearing (which appears to be 'optical' only).

There are multiple ways to badly crash nautilus afterwards.
Comment 3 Dominique Leuenberger 2013-09-24 21:05:11 UTC 
Managed to trace that one down a bit further, closing in to it:

the 'offending' extension on nautilus is gnome-user-share 
(gdb) bt

+ Trace 232534

  • #0 g_logv
    from /usr/lib64/libglib-2.0.so.0
  • #1 g_log
    from /usr/lib64/libglib-2.0.so.0
  • #2 g_signal_connect_data
    from /usr/lib64/libgobject-2.0.so.0
  • #3 nautilus_user_share_get_location_widget
    at share-extension.c line 178
  • #4 ??
  • #5 g_closure_invoke
    from /usr/lib64/libgobject-2.0.so.0
  • #6 ??
    from /usr/lib64/libgobject-2.0.so.0
  • #7 g_signal_emit_valist
    from /usr/lib64/libgobject-2.0.so.0
  • #8 g_signal_emit
    from /usr/lib64/libgobject-2.0.so.0
  • #9 ??
  • #10 ??
  • #11 ??
  • #12 ??
  • #13 g_main_context_dispatch
    from /usr/lib64/libglib-2.0.so.0
  • #14 ??
    from /usr/lib64/libglib-2.0.so.0
  • #15 g_main_context_iteration
    from /usr/lib64/libglib-2.0.so.0
  • #16 g_application_run
    from /usr/lib64/libgio-2.0.so.0
  • #17 ??
  • #18 __libc_start_main
    at libc-start.c line 269
  • #19 ?? 


(will try to get the missing debug symbols... but I think it's much more worth than what we had before).
Comment 4 Dominique Leuenberger 2013-09-24 21:28:01 UTC 
Created attachment 255651 [details] [review]
trivial: fix logic error

The bar should become visible if we are EITHER in Downloads OR in
PUBLIC.

Fixes bug 708456, which is about very strange crashes when entering
'Downloads'
Comment 5 Dominique Leuenberger 2013-09-24 21:29:31 UTC 
(In reply to comment #4)
> Created an attachment (id=255651) [details] [review]
> trivial: fix logic error
> 
> The bar should become visible if we are EITHER in Downloads OR in
> PUBLIC.

This patch changes the logic of a code-piece living there for > 4 years... no idea why this would not crash that badly, but the logic looks obviously wrong (we are likely NEVER in Public && Downloads at the same time).

I only did very few testing with this patch so far, but I can enter and leave 'Downloads' without side-effects so far.
Comment 6 Cosimo Cecchi 2013-09-24 21:31:26 UTC 
-> gnome-user-share
Comment 7 Matthias Clasen 2013-10-15 10:14:32 UTC 
Review of attachment 255651 [details] [review]:

patch looks wrong to me; the condition is supposed to catch the case that a folder is both 'downloads' and 'public', so the && is correct.
Comment 8 Mohammad DAMT 2013-10-27 16:43:43 UTC 
Created attachment 258235 [details] [review]
Check whether bar is NULL before assigning anything into it

This bug happens when bluetooth support is disabled. The current flow doesn't check the 'bar' object before connecting signals and do some other work for it and assumes that it is already created.
Comment 9 Bastien Nocera 2013-11-09 13:29:44 UTC 
Created attachment 259324 [details] [review]
share-bar: Check whether bar is NULL before using it
Comment 10 Bastien Nocera 2013-11-12 13:21:36 UTC 
Attachment 259324 [details] pushed as 3b1d2a5 - share-bar: Check whether bar is NULL before using it
Comment 11 William Jon McCann 2014-01-06 17:21:53 UTC 
*** Bug 721645 has been marked as a duplicate of this bug. ***