After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708453 - stop using libgsystem for 3.11
stop using libgsystem for 3.11
Product: gnome-desktop
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Reported: 2013-09-20 12:39 UTC by Colin Walters
Modified: 2015-02-12 23:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Drop libgsystem submodule, stop using O_NOATIME (4.76 KB, patch)
2015-02-05 19:00 UTC, Colin Walters
accepted-commit_now Details | Review

Description Colin Walters 2013-09-20 12:39:28 UTC
libgsystem grew beyond simple file stuff, and gnome-desktop is only using 2% of it; we could just copy the trivial bits now.
Comment 1 Patrick Welche 2014-09-25 15:30:21 UTC
As per Bug 735974, gnome-desktop is using only one function, gs_file_read_noatime(), from libgsystem. Is it even worth copying it (it is quite a large function once you unroll it) just to avoid updating access times? (or is there another advantage to using that function?)
Comment 2 Bastien Nocera 2014-09-26 09:47:09 UTC
I'd just copy the one file that we use from libgsystem, and add an "" helper, as we do in other cut'n'paste situations:
Comment 3 Colin Walters 2015-02-05 19:00:16 UTC
Created attachment 296234 [details] [review]
Drop libgsystem submodule, stop using O_NOATIME

The entire rationale for adding this _noatime function was fairly


But the Linux kernel doesn't permit non-root users to use it for
root-owned files - which is the default for real world GNOME
installations.  We end up doing twice the syscall traffic with no
benefit at all.

The patch does work in jhbuild, but honestly the relatime handling is
generally OK for this, and where it's not, change your system to mount
Comment 4 Colin Walters 2015-02-05 19:01:18 UTC
I want to have libgsystem potentially become more Linux specific, and having gnome-desktop depend on it is problematic from that perspective.
Comment 5 Bastien Nocera 2015-02-05 23:01:46 UTC
Review of attachment 296234 [details] [review]:

Rest looks fine.

::: libgnome-desktop/gnome-desktop-thumbnail.c
@@ -495,1 @@
             input_stream = G_INPUT_STREAM (g_file_read (file, NULL, &error));

You'll need to unmangle the indentation of that line.
Comment 6 Colin Walters 2015-02-12 23:36:24 UTC
Attachment 296234 [details] pushed as c394ae4 - Drop libgsystem submodule, stop using O_NOATIME