After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708448 - consider adding appdata
consider adding appdata
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-20 11:29 UTC by Christian Persch
Modified: 2014-02-25 16:14 UTC
See Also:
GNOME target: 3.12
GNOME version: ---


Attachments
Add appdata file (2.65 KB, patch)
2014-02-24 10:10 UTC, Daniel Mustieles
none Details | Review
AppData File (1.08 KB, patch)
2014-02-25 12:56 UTC, Daniel Mustieles
none Details | Review
Patch updated (1.06 KB, patch)
2014-02-25 15:07 UTC, Daniel Mustieles
committed Details | Review

Description Christian Persch 2013-09-20 11:29:24 UTC
http://people.freedesktop.org/~hughsient/appdata/

Not sure it's really necessary, since most likely g-t will be installed already, by default.
Comment 1 Daniel Mustieles 2014-01-21 13:00:12 UTC
It's recommendable to have it, as this application is shown in GNOME software.

If you can provide the texto for the description, I can send you a patch.

Thanks!
Comment 2 Daniel Mustieles 2014-01-21 13:02:44 UTC
Found this example in Hughsie's github (URL in wiki was wrong):

https://github.com/hughsie/fedora-appstream/blob/master/appdata-extra/desktop/gnome-termainal.appdata.xml

It's ok to use it, adding email in the <updatecontact> field?
Comment 3 Matthias Clasen 2014-02-20 01:17:36 UTC
Would be great to get this in for 3.12
Comment 4 Daniel Mustieles 2014-02-20 09:00:13 UTC
Christian, it's ok to include you in the updatecontact field? If so, I can commit this change before string freeze
Comment 5 Matthias Clasen 2014-02-22 03:42:19 UTC
I would suggest to just go without the updatecontact
Comment 6 Daniel Mustieles 2014-02-24 10:10:59 UTC
Created attachment 270100 [details] [review]
Add appdata file

Here is the patch to add the AppData file.

Please review it and, if it's ok, I'll ask for a freeze break to commit it.

Thanks!
Comment 7 Christian Persch 2014-02-24 22:18:46 UTC
I added a skeleton appdata file in git now.

+A staple for power users, the terminal helps you get in touch with your hacker roots,
+and makes it easy to get under the hood and modify your system.

No way I'm adding this :-)
Comment 8 Christian Persch 2014-02-24 22:19:24 UTC
BTW: I had wanted to use ITS to translate the appdata file, but ITS isn't integrated yet with the gnome l10n workflow, so I fell back to using intltool now for.
Comment 9 Daniel Mustieles 2014-02-25 12:33:08 UTC
So, can I modify this skeleton with the text suggested by Hugsie? (I'd prefer tou use yours, but maybe is not a good idea xDD )

Thanks!
Comment 10 Christian Persch 2014-02-25 12:43:13 UTC
It's only a skeleton, intended to be changed again, so yes, do post a patch for the <description>. However the text used in the URL in comment 2 is inacceptable. The text needs to be absolutely factual, not read like an ad.
Comment 11 Daniel Mustieles 2014-02-25 12:56:38 UTC
Created attachment 270266 [details] [review]
AppData File

Really don't like the description, but didn't know what to write... please feel free to modify it if you want
Comment 12 Christian Persch 2014-02-25 14:16:49 UTC
s/to made your life easier//. With that change, ok to commit after string freeze approval.
Comment 13 Daniel Mustieles 2014-02-25 15:07:26 UTC
Created attachment 270284 [details] [review]
Patch updated

Ok, here is the updated patch. I'm asking for a freeze break.

Thanks!
Comment 14 Daniel Mustieles 2014-02-25 16:14:22 UTC
Review of attachment 270284 [details] [review]:

Patch commited.