After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708435 - [REGRESSION] _gdk_pixbuf_new_from_uri_at_scale: Process /usr/bin/nautilus was killed by signal 11 (SIGSEGV)
[REGRESSION] _gdk_pixbuf_new_from_uri_at_scale: Process /usr/bin/nautilus was...
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: Thumbnail
3.9.x
Other Linux
: Normal critical
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
: 708417 708531 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-20 07:14 UTC by Igor Gnatenko
Modified: 2013-09-21 13:24 UTC
See Also:
GNOME target: 3.10
GNOME version: 3.9/3.10


Attachments
libgsystem: Update from master (872 bytes, patch)
2013-09-20 10:42 UTC, Bastien Nocera
committed Details | Review
fileutil: Handle recent: and trash: URIs (2.06 KB, patch)
2013-09-20 11:01 UTC, Bastien Nocera
committed Details | Review

Description Igor Gnatenko 2013-09-20 07:14:34 UTC
Bad commit: https://git.gnome.org/browse/gnome-desktop/commit/libgnome-desktop/gnome-desktop-thumbnail.c?id=d045e367cc37c774e3d76839b65aaf947b2f65ad
Tried to open recent in nautilus and its crashed.

Trace: https://bugzilla.redhat.com/show_bug.cgi?id=1010155

(gdb) p error->message
Cannot access memory at address 0x8
Comment 1 André Klapper 2013-09-20 10:41:47 UTC
*** Bug 708417 has been marked as a duplicate of this bug. ***
Comment 2 Bastien Nocera 2013-09-20 10:42:44 UTC
Created attachment 255378 [details] [review]
libgsystem: Update from master

d045e367cc37c774e3d76839b65aaf947b2f65ad is expecting
gs_file_read_noatime to always return an error, but the
commit that did that was never pulled in to gnome-desktop.

Do that now to fix possible crashers with nautilus.
Comment 3 Bastien Nocera 2013-09-20 11:01:43 UTC
Created attachment 255379 [details] [review]
fileutil: Handle recent: and trash: URIs

The gs_file_get_path_cached() was rather brittle in its handling
of URIs. It would assert() when a GFile didn't have a backing path
(such as when handling trash: or recent: URIs), and didn't know
how to get the target URI for those items either.

Make sure that we do not assert() when a backing path cannot be
found, and handle recent: and trash: URIs.
Comment 4 Bastien Nocera 2013-09-20 11:02:22 UTC
Review of attachment 255378 [details] [review]:

Obviously, this will need to be updated after we commit the following patch.
Comment 5 Igor Gnatenko 2013-09-20 11:26:06 UTC
Review of attachment 255379 [details] [review]:

Reported-and-tested-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>

After this patch bug is fixed. Thanks.
Comment 6 Colin Walters 2013-09-20 11:42:33 UTC
Review of attachment 255379 [details] [review]:

Looks good to me, thank you!
Comment 7 Matthias Clasen 2013-09-20 12:50:00 UTC
My opinion: go back to g_file_read - gs_file_read_noatime is an incomplete fork of it, and pulling in a whole copylib for this minor optimization seems misguided. Plus, it causes problems, as we're seening here.
Comment 8 Bastien Nocera 2013-09-20 13:35:34 UTC
(In reply to comment #7)
> My opinion: go back to g_file_read - gs_file_read_noatime is an incomplete fork
> of it, and pulling in a whole copylib for this minor optimization seems
> misguided. Plus, it causes problems, as we're seening here.

At this point, it's quicker to fix the code that exists that bring brand new code. There's already bug 708453 for not using libgsystem (and maybe just g_file_read() in that case).
Comment 9 Matthias Clasen 2013-09-20 13:53:42 UTC
ok
Comment 10 Bastien Nocera 2013-09-20 18:47:46 UTC
Comment on attachment 255379 [details] [review]
fileutil: Handle recent: and trash: URIs

Attachment 255379 [details] pushed as 66140c0 - fileutil: Handle recent: and trash: URIs
Comment 11 Bastien Nocera 2013-09-20 18:49:56 UTC
Attachment 255378 [details] pushed as ccc7dda - libgsystem: Update from master
Comment 12 Igor Gnatenko 2013-09-20 19:52:05 UTC
Thanks.
Comment 13 António Fernandes 2013-09-21 13:24:28 UTC
*** Bug 708531 has been marked as a duplicate of this bug. ***