After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708414 - entrycompletion: set the GtkWindow as attached to the GtkEntry
entrycompletion: set the GtkWindow as attached to the GtkEntry
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-09-19 20:59 UTC by Cosimo Cecchi
Modified: 2013-09-26 00:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
entrycompletion: set the GtkWindow as attached to the GtkEntry (1.31 KB, patch)
2013-09-19 20:59 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-09-19 20:59:38 UTC 
This was apparently forgotten when gtk_window_set_attached_to() was introduced, even if it's mentioned in the documentation of that method.
Comment 1 Cosimo Cecchi 2013-09-19 20:59:40 UTC 
Created attachment 255347 [details] [review]
entrycompletion: set the GtkWindow as attached to the GtkEntry

This way themes can easily select that window to apply custom styles.
Comment 2 Matthias Clasen 2013-09-19 23:25:02 UTC 
Review of attachment 255347 [details] [review]:

does the attaching make the set_accessible_relation call unnecessary ?
Comment 3 Cosimo Cecchi 2013-09-19 23:39:08 UTC 
I don't think so - I don't see any code that uses the attached-to property to infer accessibility relationships.
Comment 4 Matthias Clasen 2013-09-19 23:59:23 UTC 
Review of attachment 255347 [details] [review]:

ok, then
Comment 5 Matthias Clasen 2013-09-26 00:08:21 UTC 
Attachment 255347 [details] pushed as 6f9fed4 - entrycompletion: set the GtkWindow as attached to the GtkEntry