After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708404 - Use markup for superscript in text string
Use markup for superscript in text string
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-19 19:31 UTC by Khaled Hosny
Modified: 2014-03-04 00:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.30 KB, patch)
2014-03-03 22:38 UTC, Khaled Hosny
committed Details | Review

Description Khaled Hosny 2013-09-19 19:31:27 UTC
There is a " km²" string in the translation, but the use of Unicode superscript should be avoided as Unicode superscripts are encoded for use in specific linguistic context and not for general text superscripts, instead Pango markup should be used https://developer.gnome.org/pango/stable/PangoMarkupFormat.html, so it should be " km<sup>2</sup>" (while making sure its interpreted as markup of course). Pango markup has the additional benefit that other digits can be used for the superscript, e.g. for Arabic or Persian translations where the European digits are not used.

I would have came up with a patch myself, but I didn’t manage to get maps running out of git checkout.
Comment 1 Zeeshan Ali 2013-09-19 20:05:21 UTC
I'm afraid we are too far into freezes to do this. No need for patch, just get us a freeze break and I can easily fix it: https://wiki.gnome.org/ReleasePlanning/Freezes
Comment 2 Khaled Hosny 2013-09-19 20:21:30 UTC
I don’t think it is worth breaking the string freeze that late, so it can wait to after 3.10 branching.
Comment 3 Khaled Hosny 2014-02-28 20:52:33 UTC
Can this be done for 3.12 now?
Comment 4 Zeeshan Ali 2014-03-02 14:42:19 UTC
(In reply to comment #3)
> Can this be done for 3.12 now?

Too late. We are already in a freeze but we can ask for exceptions. Things would have gone faster if there was a patch submitted for this. :(
Comment 5 Zeeshan Ali 2014-03-02 14:44:04 UTC
(In reply to comment #0)
> 
> I would have came up with a patch myself, but I didn’t manage to get maps
> running out of git checkout.

Can you try now? Have you tried jhbuild? A patch against 3.10 won't be bad either.
Comment 6 Khaled Hosny 2014-03-03 22:38:25 UTC
Created attachment 270851 [details] [review]
Patch

I can’t get master too build (too new dependencies) and jhbuild is an overkill for such a simple fix, so I tested it with 3.10 then rebased the patch on master.
Comment 7 Zeeshan Ali 2014-03-04 00:08:34 UTC
Thanks!