After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708399 - Use better icons
Use better icons
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: Telepathy
3.9.x
Other All
: High critical
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
3.10.1
Depends on:
Blocks:
 
 
Reported: 2013-09-19 18:34 UTC by Bastian Ilsø
Modified: 2013-10-05 10:15 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10

Attachments
screenshot of distorted jabber icon (125.06 KB, image/png)
2013-09-19 18:34 UTC, Bastian Ilsø 		  Details
When adding an account (20.17 KB, image/png)
2013-10-02 20:26 UTC, Debarshi Ray 		  Details
When showing an account (26.88 KB, image/png)
2013-10-02 20:27 UTC, Debarshi Ray 		  Details
telepathy: Use user-available-symbolic as the provider icon (1.27 KB, patch)
2013-10-02 20:31 UTC, Debarshi Ray 		none Details | Review
telepathy: Choose better icons (1.74 KB, patch)
2013-10-05 10:02 UTC, Debarshi Ray 		committed Details | Review
When adding an account (23.30 KB, image/png)
2013-10-05 10:11 UTC, Debarshi Ray 		  Details

Description Bastian Ilsø 2013-09-19 18:34:19 UTC 
Created attachment 255334 [details]
screenshot of distorted jabber icon

When your mouse hover the Jabber icon in the interface, the jabber icon is distorted. Aliasing and jagged line appear, rendering the icon rather ugly. See the bottom jabber icon in the attached screenshot.
Comment 1 Allan Day 2013-09-26 12:36:03 UTC 
The icon is pretty bad any way. I think we should use a generic symbolic icon for unbranded account types (like we do for unbranded mail accounts, like IMAP).
Comment 2 Matthias Clasen 2013-10-02 19:15:30 UTC 
do we have a suitable icon for this ?
Comment 3 Allan Day 2013-10-02 20:00:45 UTC 
I recommended using user-available-symbolic for all the unbranded chat accounts (XMPP, IRC, etc) when the feature was in development.
Comment 4 Debarshi Ray 2013-10-02 20:26:30 UTC 
Created attachment 256324 [details]
When adding an account
Comment 5 Debarshi Ray 2013-10-02 20:27:10 UTC 
Created attachment 256325 [details]
When showing an account
Comment 6 Debarshi Ray 2013-10-02 20:31:35 UTC 
Created attachment 256326 [details] [review]
telepathy: Use user-available-symbolic as the provider icon
Comment 7 Debarshi Ray 2013-10-03 16:22:22 UTC 
Jimmac wants the icons to be dimmed, but I don't see a way to do this unless GTK+ learns to dim the colour of the symbolic icons.

In case you are wondering how GtkPlacesSidebar manages to do it, placing a symbolic inside a GtkTreeview automatically dims it for some reason.
Comment 8 Debarshi Ray 2013-10-05 10:02:30 UTC 
Created attachment 256532 [details] [review]
telepathy: Choose better icons
Comment 9 Debarshi Ray 2013-10-05 10:04:43 UTC 
After some discussion on IRC we decided to use the symbolic icons for the generic protocols, icons for the branded ones if it matches their visual identity, and otherwise no icon.

We will dim the symbolics once GTK+ learns how to do it.

Will ask for UI freeze break before pushing to gnome-3-10.
Comment 10 Debarshi Ray 2013-10-05 10:10:54 UTC 
Comment on attachment 256532 [details] [review]
telepathy: Choose better icons

Pushed to master.
Comment 11 Debarshi Ray 2013-10-05 10:11:34 UTC 
Created attachment 256533 [details]
When adding an account