After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708376 - autogen.sh --simple-install option is broken
autogen.sh --simple-install option is broken
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2013-09-19 13:58 UTC by David King
Modified: 2013-09-19 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix the --simple-install case (1.19 KB, patch)
2013-09-19 14:00 UTC, David King
committed Details | Review

Description David King 2013-09-19 13:58:39 UTC
As Carlos Soriano pointed out to me on IRC, using --simple-install with autogen.sh was broken by commit 3d03dc2487d128b949cde5e8b3b5a06d9ab40f89 because it wrongly assumed that 0 was true and 1 was false, when the enable_autotools variable treated them the other way around. I have a patch that inverts the interpretation again and works fine (tested with and without --simple-install and with and without the required autotools dependencies installed).
Comment 1 David King 2013-09-19 14:00:02 UTC
Created attachment 255303 [details] [review]
fix the --simple-install case
Comment 2 Colin Walters 2013-09-19 14:23:20 UTC
Review of attachment 255303 [details] [review]:

Right.
Comment 3 David King 2013-09-19 14:28:46 UTC
Comment on attachment 255303 [details] [review]
fix the --simple-install case

Thanks, pushed to master as commit 9ed3db648d6096c02f3937e7273eccfd436c227d.