GNOME Bugzilla – Bug 708346
gnome-terminal does not respect "Disable mnemonics" and "Disable menubar F10" settings in preferences
Last modified: 2014-03-25 00:18:27 UTC
Description of problem: Since I use irssi, I'd like to be able to use my "q,w,e,r,t,y.." keyboard row to access channels 11-20. However, gnome-terminal doesn't release these, even after I've unchecked the "Enable mnemonics" setting in preferences. Version-Release number of selected component (if applicable): gnome-terminal-3.9.90-1.fc20.x86_64 How reproducible: Always Steps to Reproduce: 1.Disable mnemonics in preferences 2.try alt + e 3. Actual results: Still opens the edit menu Expected results: Should not open the edit menu. Additional info: Would it be possible to disable all terminal shortcuts? For example, I manually disabled the "alt 1-0" shortcuts so I could use them in irssi. Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1009786
Gtk+ bug. Commit 7e3a494fac62140f466fc43f6cc061215953e9b1 deprecated the gtk-enable-mnemonics setting, and removed all code to handle it.
Also the disabling of F10 is broken in g-t, due to gtk commit b26c74e5dac0b5fd869d2c8cc7a0edb6b01aeebd which deprecate-and-ignore'd the gtk-menu-bar-accel setting.
Ah! Thanks Christian. Are these going to be re-added in Gtk+, or are these settings going to be removed in g-t? I mean, what is the solution forward from here? Does this mean there won't be a way of disabling these at all? Warm regards, Ankur
this should work with 3.10 - gnome-terminal should still be working towards another solution
Should I now file a bug against gnome-terminal, since the mnemonic settings are still useless there as of 3.10? [asinha@localhost ~]$ rpm -q gnome-terminal gnome-terminal-3.10.0-1.fc20.x86_64 [asinha@localhost ~]$
Which gtk3 version? And did you make sure to restart gnome-terminal-server process after the upgrade? In future this will be fixed in g-t by removing the menubar (bug 672433).
[asinha@localhost ~]$ rpm -q gtk3 gtk3-3.10.0-1.fc20.x86_64 I have restarted the system since the update, yes. I'll recheck again, though, just to be sure. Thanks, Ankur
Yep. I've restarted the system but the mnemonics still work here. I even have the option unselected in preferences: gtk3-3.10.0-1.fc20.x86_64 gnome-terminal-3.10.0-1.fc20.x86_64 Thanks, Ankur
I'm still seeing this bug in F-20 with gtk3-3.10.0-1.fc20.x86_64 and gnome-terminal-3.10.0-1.fc20.x86_64 This bug makes using emacs-like keybindings (Alt+b) pretty much useless in gnome-terminal.
*** Bug 709764 has been marked as a duplicate of this bug. ***
This works as expected when running with gtk 3.8, so someone will need to git bisect between 3.8.0 and 3.10.0 tags to find which commit broke this (and why the revert doesn't fix it).
https://wiki.gnome.org/Apps/Terminal/Debugging will come in handy when doing the bisect.
I bisected gtk+ and found the commit: 7e3a494fac62140f466fc43f6cc061215953e9b1 . Are there any gt developers reading this? Maybe it's obvious to them how to fix this in gt?
And that's what https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-10&id=34cf40e95cb1f0bc4bb98bb14edb03dd86f1dab3 reverted partially... to no success.
Created attachment 257172 [details] [review] patch to allow disabling mnemonics in gtkwindow
The part in GtkWindow wasn't restored. The patch above against 34cf40e95cb1f0bc4bb98bb14edb03dd86f1dab3 fixes that.
Created attachment 257173 [details] [review] same patch as above, but with "From:" line
(In reply to comment #17) > Created an attachment (id=257173) [details] [review] > same patch as above, but with "From:" line I can confirm the patch to work on my system; Alt-F no longer opens the gnome-terminal menu. I applied the patch on top of GTK+ 3.10.1
Hi, Any chance this can be fixed in 3.10.1, or is it too late for that now? Thanks, Ankur
Fixed for me. Thanks: gtk3-3.10.2-2.fc20.x86_64
This seems to have crept back in: [asinha@ankur-laptop ~]$ rpm -q gtk3 gtk3-3.11.7-1.fc20.x86_64 Disabling mnemonics in the settings has no effect on using "alt f" etc. again. Reopening.
[asinha@ankur-laptop ~]$ rpm -q gnome-terminal gnome-terminal-3.11.0-2.fc20.x86_64
It has not 'crept back in'. The setting was only granted a stay for the 3.10 cycle. The plan going forward is for gnome-terminal to get rid of its menubar.
And now I've granted it another stay for 3.12
I don't know why, but for current master/3.12 this issue is still present; disabling mnemonics in gnome-terminal's settings still opens the File menu when pressing Alt+F.
I should mention that the setting for disabling/enabling the menu accelerator (F10) works correctly.
I think you forgot to undo some of this: https://git.gnome.org/browse/gtk+/diff/gtk/gtkwindow.c?id=7e3a494fac62140f466fc43f6cc061215953e9b1 in commit https://git.gnome.org/browse/gtk+/commit/?id=ba0542dc51f89a0df0b42c26eaab530143c0678c ?
Created attachment 272810 [details] [review] window: Respect gtk-enable-mnemonics setting This part was forgotten to be undone in commit ba0542dc51f8, so that disabling mnemonics in gnome-terminal still didn't work.
Btw, I just found the same patch, also as a follow up, on the 3.10 branch: https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-10&id=75a6a8fbe20560022f9c9f0b830f29edf05750ec