After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708340 - overviewControls: Don't allow appearing controls to "pop in"
overviewControls: Don't allow appearing controls to "pop in"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-19 00:26 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-09-26 18:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overviewControls: Don't allow appearing controls to "pop in" (3.25 KB, patch)
2013-09-19 00:26 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-09-19 00:26:15 UTC 
When coming back from search or apps, the workspace thumbnails and dash
don't slide in but "pop in". This is because of bad timing: when slideIn
is called, we immediately start the translation animation, and it
completes before by the time we fade the new page in.

Fix this by calling slideIn and slideOut at two different times: we now
slide out when the old page with our controls is fading out, and slide in
when the new page with our controls is fading in.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-09-19 00:26:17 UTC 
Created attachment 255265 [details] [review]
overviewControls: Don't allow appearing controls to "pop in"
Comment 2 drago01 2013-09-26 17:55:25 UTC 
Review of attachment 255265 [details] [review]:

Looks good.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-09-26 18:06:41 UTC 
Attachment 255265 [details] pushed as e31693b - overviewControls: Don't allow appearing controls to "pop in"