After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708324 - entry grows out of password dialog
entry grows out of password dialog
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-18 19:34 UTC by Matthias Clasen
Modified: 2013-09-19 05:55 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
keyring: Don't allow ellipsization of Password label (1.27 KB, patch)
2013-09-18 19:45 UTC, Florian Müllner 		committed Details | Review
networkAgent: Don't allow ellipsization of Password label (1.18 KB, patch)
2013-09-18 20:38 UTC, Florian Müllner 		committed Details | Review

Description Matthias Clasen 2013-09-18 19:34:51 UTC 
1. Lock your keyring (context menu in seahorse has a 'lock' item)
2. Unlock it again to get the shell dialog ('unlock' item in seahorse context menu will do)
3. Hold down the a key for a while
4. Observe the entry growing out of the dialog, and across the screen
Comment 1 Florian Müllner 2013-09-18 19:41:31 UTC 
It is a lot better with the keyring patch from bug 703833 (and the remaining issue is easy to fix) - can we just get that landed?
Comment 2 Florian Müllner 2013-09-18 19:45:55 UTC 
Created attachment 255248 [details] [review]
keyring: Don't allow ellipsization of Password label

We don't want the password entry to grow when entering more characters
that fit the available width; as labels' ClutterText ellipsizes by
default, the password label allows the entry to grow by shrinking.
Setting the appropriate ellipsize mode fixes this.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-09-18 20:25:52 UTC 
Review of attachment 255248 [details] [review]:

OK.
Comment 4 Florian Müllner 2013-09-18 20:38:14 UTC 
Created attachment 255252 [details] [review]
networkAgent: Don't allow ellipsization of Password label

So I checked, and the network dialog has the same problem ...
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-09-18 21:37:49 UTC 
Review of attachment 255252 [details] [review]:

OK.
Comment 6 Florian Müllner 2013-09-19 05:55:28 UTC 
Attachment 255248 [details] pushed as 30e7440 - keyring: Don't allow ellipsization of Password label
Attachment 255252 [details] pushed as 39134f0 - networkAgent: Don't allow ellipsization of Password label