After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708279 - Two patches for buttons in the headerbar
Two patches for buttons in the headerbar
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-18 11:46 UTC by Yosef Or Boczko
Modified: 2013-09-26 09:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make the cancel button as center vertically (729 bytes, patch)
2013-09-18 11:46 UTC, Yosef Or Boczko 		accepted-commit_now Details | Review
Make the close button consistent with a standard headerbar (702 bytes, patch)
2013-09-18 11:46 UTC, Yosef Or Boczko 		accepted-commit_now Details | Review
Make the close button consistent with a standard headerbar (760 bytes, patch)
2013-09-26 09:56 UTC, Vadim Rutkovsky 		committed Details | Review

Description Yosef Or Boczko 2013-09-18 11:46:22 UTC 
Make the cancel button as center vertically and
Make the close button consistent with a standard headerbar.
Comment 1 Yosef Or Boczko 2013-09-18 11:46:44 UTC 
Created attachment 255170 [details] [review]
Make the cancel button as center vertically
Comment 2 Yosef Or Boczko 2013-09-18 11:46:54 UTC 
Created attachment 255171 [details] [review]
Make the close button consistent with a standard headerbar
Comment 3 Arnel Borja 2013-09-26 03:59:49 UTC 
Review of attachment 255170 [details] [review]:

Accepted for committing to master. Approved by Vadim (maintainer).
Comment 4 Arnel Borja 2013-09-26 04:00:20 UTC 
Review of attachment 255171 [details] [review]:

Accepted for committing to master. Approved by Vadim (maintainer).
Comment 5 Vadim Rutkovsky 2013-09-26 09:56:26 UTC 
The following fixes have been pushed:
1f51460 Make the close button consistent with a standard headerbar
62b8177 Make the cancel button as center vertically

to master and gnome-3-10 branch
Comment 6 Vadim Rutkovsky 2013-09-26 09:56:30 UTC 
Created attachment 255805 [details] [review]
Make the close button consistent with a standard headerbar