After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708275 - newer pylint breaks `make check`
newer pylint breaks `make check`
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
3.12
Depends on:
Blocks:
 
 
Reported: 2013-09-18 11:05 UTC by Benedikt Morbach
Modified: 2013-10-01 00:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that removes the '-i' option from Makefile.plugins (823 bytes, patch)
2013-09-18 11:05 UTC, Benedikt Morbach
committed Details | Review

Description Benedikt Morbach 2013-09-18 11:05:42 UTC
Created attachment 255161 [details] [review]
Patch that removes the '-i' option from Makefile.plugins

pylint 1.0.0 doesn't have the '-i' option.
This breaks `make check` if --enable-python is given.
Comment 1 Bastien Nocera 2013-09-24 16:30:27 UTC
I'd gladly accept that if it weren't for the fact that pylint fails anyway.
Also, the machine on which I distcheck still has an old pylint, so this would only be needed when I (or the other people doing releases) upgrade.
Comment 2 Philip Withnall 2013-10-01 00:39:06 UTC
commit bef67e38b1cbd4b1c388e66239362fec932c235d
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Tue Oct 1 01:26:57 2013 +0100

    plugins: Remove ‘check-pylint’ as a prerequisite of ‘check’
    
    pylint can be useful, but since the initial round of fixes it’s just been
    noise. Tools run by `make check` should be useful, not a hurdle.
    
    Helps: https://bugzilla.gnome.org/show_bug.cgi?id=708275

commit 7846c033a05126c282b3d4d8a492cc5a07383742
Author: Benedikt Morbach <benedikt.morbach@googlemail.com>
Date:   Wed Sep 18 12:49:11 2013 +0200

    pylint 1.0.0 doesn't have the -i option, remove it
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=708275

commit 6a48e159e5eac79c5c44401cee4b8933e0d1ea60
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Tue Oct 1 01:22:54 2013 +0100

    dbusservice: pylintify the code
    
    Shut up, pylint.
    
    Helps: https://bugzilla.gnome.org/show_bug.cgi?id=708275

commit 948a9e0162cfea8f788c9a45200530eec021691c
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Tue Oct 1 01:22:40 2013 +0100

    opensubtitles: pylintify the code
    
    Shut up, pylint.
    
    Helps: https://bugzilla.gnome.org/show_bug.cgi?id=708275

commit ed8bf5168356c01c2c41699f554b1f9553cd025d
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Tue Oct 1 01:21:26 2013 +0100

    pythonconsole: pylintify the code
    
    Shut up, pylint.
    
    Helps: https://bugzilla.gnome.org/show_bug.cgi?id=708275

commit c9004246b5d2ccae7db1729c098f82d07c026094
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Tue Oct 1 00:56:38 2013 +0100

    pythonconsole: Convert from tabs to spaces
    
    I’m really sorry this is necessary. pylint made me do it.
    
    Helps: https://bugzilla.gnome.org/show_bug.cgi?id=708275