GNOME Bugzilla – Bug 708255
VPN ConnectInteractive -> Connect fallback doesn't actually work
Last modified: 2013-09-27 12:34:07 UTC
the ConnectInteractive -> Connect fallback code doesn't work, because _connect_internal() changes the state to NM_VPN_SERVICE_STATE_STARTING before checking if it can implement ConnectInteractive, and then when the Connect call comes in, the VPN is not in STOPPED or INIT, so it returns an error.
The fix is available in jklimes/bgo708255-vpn-fix branch. Please review it.
Looks good to me. If anything, I would: - squash "vpn: use constants instead of literal value for VPN plugin errors" - remove trailing space in "vpn: fix connecting to VPN (bgo #708255)" (nm-vpn-connection.c)
I would also combine "vpn: return INTERACTIVE_NOT_SUPPORTED for NewSecrets() when not implemented" and "vpn: fix connecting to VPN (bgo #708255)" I think. Other than that, looks good.
Commits updated accordingly and pushed: 9dff830692c8ff0fe69291e4bc882e4060d77542 282b9df60d8dcfaea14e927721ff99968bc22721