After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708229 - Add function for checking if an address has already been allocated.
Add function for checking if an address has already been allocated.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other All
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-17 12:13 UTC by Patrick Radizi
Modified: 2014-02-25 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch with new function gst_rtsp_address_pool_is_allocated () (3.74 KB, patch)
2013-09-17 12:13 UTC, Patrick Radizi 		none Details | Review
Functionality added to gst_rtsp_address_pool_reserve_address (13.02 KB, patch)
2013-09-22 21:16 UTC, Patrick Radizi 		none Details | Review

Description Patrick Radizi 2013-09-17 12:13:44 UTC 
Created attachment 255092 [details] [review]
Patch with new function gst_rtsp_address_pool_is_allocated ()

It would be good to have a function for checking if an address has already been allocated from am address pool. Otherwise if a call to gst_rtsp_address_pool_reserve_address () returns NULL the caller has no way of knowing if it returned NULL because the address range was not in the pool to begin with or if it has already been reserved.

I have made an implementation of such a function, gst_rtsp_address_pool_is_allocated . See attachement.
Comment 1 Patrick Radizi 2013-09-22 21:16:24 UTC 
Created attachment 255538 [details] [review]
Functionality added to gst_rtsp_address_pool_reserve_address

After discussion with Wim I changed the implementation to add the functionality to gst_rtsp_address_pool_reserve_address() instead of adding a new function.
Comment 2 Wim Taymans 2013-09-24 15:34:03 UTC 
commit 7b0ad7c25f7f5eaa5ef8902a4ab299d57318edfd
Author: Patrick Radizi <patrick.radizi at axis.com>
Date:   Tue Sep 24 17:30:18 2013 +0200

    addresspool: return reason of failure
    
    Let gst_rtsp_address_pool_reserve_address() return the reason why
    the address could not be reserved.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=708229