After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708228 - Add poppler to the manifest
Add poppler to the manifest
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks: 708227
 
 
Reported: 2013-09-17 11:58 UTC by Debarshi Ray
Modified: 2013-09-19 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
manifest: Add poppler (1.38 KB, patch)
2013-09-19 09:12 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-09-17 11:58:47 UTC 
Poppler is needed for reading PDFs via gnome-documents and evince.
Comment 1 Debarshi Ray 2013-09-17 12:11:15 UTC 
It needs openjpeg for JPEG 2000 support: http://code.google.com/p/openjpeg/
Comment 2 Debarshi Ray 2013-09-17 12:16:40 UTC 
We can build poppler with --disable-poppler-cpp because the C++ wrapper doesn't seem to be used.
Comment 3 Debarshi Ray 2013-09-18 15:21:31 UTC 
It is worth noting that cmake is required for building openjpeg. In the worst case we will have to build poppler without it.
Comment 4 Debarshi Ray 2013-09-18 15:26:01 UTC 
Turns out that openjpeg-1.5.1 can be built without cmake, so we can stick to it for the moment.
Comment 5 Debarshi Ray 2013-09-19 09:12:03 UTC 
Created attachment 255277 [details] [review]
manifest: Add poppler
Comment 6 Debarshi Ray 2013-09-19 09:12:53 UTC 
The poppler regression tests come in a different Git repository. I don't know if we want to add them or not.
Comment 7 Colin Walters 2013-09-19 13:16:36 UTC 
Review of attachment 255277 [details] [review]:

Looks fine to me, thanks!
Comment 8 Debarshi Ray 2013-09-19 14:05:58 UTC 
Comment on attachment 255277 [details] [review]
manifest: Add poppler

Pushed. Thanks for the review.