After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708221 - mp4dashmux: add the tfdt atom to the moof
mp4dashmux: add the tfdt atom to the moof
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 668091
Blocks:
 
 
Reported: 2013-09-17 10:28 UTC by Andoni Morales
Modified: 2017-01-07 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mp4dashmux: add the tfdt atom to the moof (5.81 KB, patch)
2013-09-17 10:28 UTC, Andoni Morales
accepted-commit_now Details | Review
qtmux: Write tfdt atom into fragmented files. (4.42 KB, patch)
2017-01-07 14:23 UTC, Jan Schmidt
none Details | Review

Description Andoni Morales 2013-09-17 10:28:55 UTC
Include the tfdt atoms in the moof, which set the base
decode time of the fragment
Comment 1 Andoni Morales 2013-09-17 10:28:57 UTC
Created attachment 255087 [details] [review]
mp4dashmux: add the tfdt atom to the moof

This atoms is used to the set the base decode time for fragments
and allows the demuxer to set the correct base time in buffers
when pushing a new fragment in the middle of the stream.
Comment 2 Thiago Sousa Santos 2013-09-30 21:33:53 UTC
Review of attachment 255087 [details] [review]:

Looks good. Marking as commit now, but obviously it needs to wait for the dependent bugs to be solved first.
Comment 3 Jan Schmidt 2017-01-07 14:23:48 UTC
I just wrote a nearly identical patch 3 years later. Pushing that shortly.
Comment 4 Jan Schmidt 2017-01-07 14:23:57 UTC
Created attachment 343089 [details] [review]
qtmux: Write tfdt atom into fragmented files.

The DASH spec requires that tfdt atoms be present, so
write one out. ISO/IEC 23009-1:2014 6.3.4.2
Comment 5 Jan Schmidt 2017-01-07 14:25:21 UTC
I don't think it actually depends on the DASH bug, btw - DASH makes TFDT mandatory, but it's valid / useful for any fragmented stream.
Comment 6 Jan Schmidt 2017-01-07 14:26:55 UTC
commit 12ad37fdb364b20cf0d93a37d3c9c74a6b50d48c
Author: Jan Schmidt <jan@centricular.com>
Date:   Sun Jan 8 01:13:32 2017 +1100

    qtmux: Write tfdt atom into fragmented files.
    
    The DASH spec requires that tfdt atoms be present, so
    write one out. ISO/IEC 23009-1:2014 6.3.4.2
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708221