After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708214 - Need context for string
Need context for string
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-17 09:27 UTC by Daniel Mustieles
Modified: 2014-12-25 18:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use C_() instead of _() in strings (1.43 KB, patch)
2013-09-19 07:50 UTC, Daniel Mustieles
none Details | Review

Description Daniel Mustieles 2013-09-17 09:27:32 UTC
There is a string that needs to have a context set, to distinct it's genre:

#. Translators: "New" refers to an alarm
#. Translators: "New" refers to a world clock
#: ../src/alarm.vala:487 ../src/world.vala:278
msgid "New"

In several languages, "alarm" has a female genre, and "clock" has a male one, so it's needed to distinct the string in both contexts. Setting it is enough to have the same string with different translations.

Thanks!

P.S. This change will need a freeze break, so please inform about it before changing it ;)
Comment 2 Daniel Mustieles 2013-09-19 07:50:08 UTC
Created attachment 255273 [details] [review]
Use C_() instead of _() in strings

Here is a patch to fix this. It would be possible to land it before 3.10 release?

Thanks André for the info :)
Comment 3 Paolo Borelli 2013-09-19 08:28:45 UTC
Please ask for a freeze break, if it is accepted the patch looks good to me
Comment 4 Evgeny Bobkin 2013-09-19 09:14:35 UTC
well, then we do not need this comments any more: 

// Translators: "New" refers to an alarm
Comment 5 Daniel Mustieles 2013-09-19 09:18:19 UTC
(In reply to comment #4)
> well, then we do not need this comments any more: 
> 
> // Translators: "New" refers to an alarm

I't doesn't disturb, and may help if the translation tool doesn't show the context message, so I'd maintain it.
Comment 6 Evgeny Bobkin 2013-09-19 09:31:16 UTC
(In reply to comment #0)
> There is a string that needs to have a context set, to distinct it's genre:
> 
> #. Translators: "New" refers to an alarm
> #. Translators: "New" refers to a world clock
> #: ../src/alarm.vala:487 ../src/world.vala:278
> msgid "New"
> 
> In several languages, "alarm" has a female genre, and "clock" has a male one,
> so it's needed to distinct the string in both contexts. Setting it is enough to
> have the same string with different translations.
> 
> Thanks!
> 
> P.S. This change will need a freeze break, so please inform about it before
> changing it ;)

If you will not be able to get through the freeze break, then I have a translation hint for you. In Russian the adjectives changes as well depending on masculine of feminine gender, and there we have preplaced adjective "New" with the verb "Create" which remains neutral.

So for example: "New Clock" -> "Новые часы"      turned to "Создать Часы"
                "New Alarm" -> "Новый Будильник" turned to "Создать Будильник"

And I believe, that you can apply the same pattern.
Comment 7 Daniel Mustieles 2013-09-19 09:56:43 UTC
(In reply to comment #6)
> (In reply to comment #0)
> > There is a string that needs to have a context set, to distinct it's genre:
> > 
> > #. Translators: "New" refers to an alarm
> > #. Translators: "New" refers to a world clock
> > #: ../src/alarm.vala:487 ../src/world.vala:278
> > msgid "New"
> > 
> > In several languages, "alarm" has a female genre, and "clock" has a male one,
> > so it's needed to distinct the string in both contexts. Setting it is enough to
> > have the same string with different translations.
> > 
> > Thanks!
> > 
> > P.S. This change will need a freeze break, so please inform about it before
> > changing it ;)
> 
> If you will not be able to get through the freeze break, then I have a
> translation hint for you. In Russian the adjectives changes as well depending
> on masculine of feminine gender, and there we have preplaced adjective "New"
> with the verb "Create" which remains neutral.
> 
> So for example: "New Clock" -> "Новые часы"      turned to "Создать Часы"
>                 "New Alarm" -> "Новый Будильник" turned to "Создать Будильник"
> 
> And I believe, that you can apply the same pattern.

That's a good point. Thanks!

It's a trivial change, but may affect several languages, so I hope i18n and rt will have no problem to accept the freeze break
Comment 8 Daniel Mustieles 2013-10-09 16:21:47 UTC
I'd like to fix this bug before 3.10.1... could you create a gnome-3-10 branch, so this patch can be applied in master one?

Thanks!
Comment 9 Paolo Borelli 2014-12-25 18:01:29 UTC
I guess this never happened for that old branch, but at this point it does not matter anymore.

On master it is been ok for a long time