GNOME Bugzilla – Bug 708210
missing pkgconfig checks in mutter-wayland 3.9.92
Last modified: 2013-09-20 21:09:26 UTC
http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20130917082314.ovitters.valstar.11085/log/mutter-wayland-3.9.92-1.mga4/build.0.20130917082406.log CC monitor.lo core/keybindings.c: In function 'meta_display_get_keybinding_action': core/keybindings.c:944:3: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1699) [-Wdeprecated-declarations] keysym = XKeycodeToKeysym (display->xdisplay, keycode, 0); ^ core/main.c:270:3: warning: 'cogl_get_option_group' is deprecated (declared at /usr/include/cogl/cogl/cogl1-context.h:55) [-Wdeprecated-declarations] g_option_context_add_group (ctx, cogl_get_option_group ()); ^ core/display.c:3543:9: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1699) [-Wdeprecated-declarations] keysym = XKeycodeToKeysym (display->xdisplay, device_event->detail, 0); ^ core/keybindings.c: In function 'meta_display_process_key_event': core/keybindings.c:2085:3: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1699) [-Wdeprecated-declarations] keysym = XKeycodeToKeysym (display->xdisplay, event->detail, 0); ^ CC monitor-config.lo cc1: all warnings being treated as errors CC monitor-kms.lo make[4]: *** [main.lo] Error 1 make[4]: *** Waiting for unfinished jobs.... core/meta-cursor-tracker.c: In function 'get_pointer_position_clutter': core/meta-cursor-tracker.c:1020:3: error: implicit declaration of function 'clutter_input_device_get_modifier_state' [-Werror=implicit-function-declaration] *mods = clutter_input_device_get_modifier_state (cdevice); ^ core/meta-cursor-tracker.c:1020:3: error: nested extern declaration of 'clutter_input_device_get_modifier_state' [-Werror=nested-externs] cc1: all warnings being treated as errors make[4]: *** [meta-cursor-tracker.lo] Error 1 core/monitor-kms.c: In function 'meta_monitor_manager_kms_read_current': core/monitor-kms.c:483:49: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (manager->crtcs[j].crtc_id == output_kms->current_encoder->crtc_id) ^ cc1: all warnings being treated as errors
1) Why all warnings are treated as errors? Even when distchecking, deprecations and sign comparisons should not fail the build 2) For the nested extern warning, you need a newer clutter.
spec file is at: http://svnweb.mageia.org/packages/cauldron/mutter-wayland/current/SPECS/mutter-wayland.spec?view=markup We do an: autoreconf -ifv Because the following patch: http://svnweb.mageia.org/packages/cauldron/mutter-wayland/current/SOURCES/mutter-disable-cast-align.patch?view=markup This patch was included in our Mutter 3.9.92. It disables -Wcast-align. I copied the spec for mutter-wayland from mutter. If the autoreconf causes the: cc1: all warnings being treated as errors plus if that patch is not needed, then I can try building without it. Note: there is also another patch: http://svnweb.mageia.org/packages/cauldron/mutter-wayland/current/SOURCES/0001-MonitorXrandr-Attempt-to-mask-a-BadValue-error-on-Vi.patch?view=markup this was included in Mutter 3.9.92, but not in mutter-wayland. Could you update configure.ac to check for a newer clutter?
The newer clutter is not released yet, Emmanuele said he would make a late release after the HiDPI support lands.
configure.ac should check for the following pkgconfig items: BuildRequires: pkgconfig(clutter-wayland-1.0) >= 1.15.94 BuildRequires: pkgconfig(clutter-wayland-compositor-1.0) >= 1.15.94 BuildRequires: pkgconfig(clutter-egl-1.0) >= 1.15.94 Otherwise you get weird build failures. Once clutter has support for above 3 things, it builds fine :)
Hmm, once it builds, once it fails due to the following: core/monitor-kms.c: In function 'meta_monitor_manager_kms_read_current': core/monitor-kms.c:483:49: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (manager->crtcs[j].crtc_id == output_kms->current_encoder->crtc_id) ^ cc1: all warnings being treated as errors Going to add a patch to ignore -Werror=sign-compare.
the -Werror was removed by doing: --enable-compile-warnings=maximum. I'm guessing I should clean the spec now :P Bug now solely for the missing pkgconfig checks.
Created attachment 255382 [details] [review] configure: update dependencies for clutter packages Make sure that clutter is at the right minimum version for the API we use, and that it is built with the right configure flags, by checking for subpackage .pcs too.
Review of attachment 255382 [details] [review]: OK.
Attachment 255382 [details] pushed as 90854a0 - configure: update dependencies for clutter packages