After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708195 - attributes not drawn on graphic characters
attributes not drawn on graphic characters
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-16 20:59 UTC by Christian Persch
Modified: 2014-11-22 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (50.80 KB, patch)
2014-07-26 21:23 UTC, Egmont Koblinger 		committed Details | Review

Description Christian Persch 2013-09-16 20:59:13 UTC 
As identified in bug 707221, the graphic characters are missing the attributes.
Comment 1 Egmont Koblinger 2014-07-26 19:40:46 UTC 
This is really not an important issue, but soon it'll be the last missing bit from passing vttest's first two tests (apart from blinking which we won't support).

I think the special handling of these chars should be moved to lower level where the actual glyphs are drawn, that is, vtedraw.c:_vte_draw_text_internal().
Comment 2 Egmont Koblinger 2014-07-26 21:23:20 UTC 
Created attachment 281794 [details] [review]
Fix

This is what I had in mind.

Please double check that I'm hooking up at the right place in _vte_draw_text_internal().
Comment 3 Behdad Esfahbod 2014-07-26 21:24:45 UTC 
Looks about right to me.