GNOME Bugzilla – Bug 708181
Wayland: Wrap X11 specific gdk calls
Last modified: 2015-02-14 15:17:40 UTC
Created attachment 255059 [details] [review]
wrap gdk_x11_* calls with runtime and compile checks
This is the same type of problem as in 707254. Glad to know I'm not the only one who has run into this issue. Before trying the following, I was able to get the same solution you used to work successfully with gtk3-quartz on OS X. However, after browsing through the documentation, I eventually came up with the following:
What worked for me was to replace all <gdk/gdkx.h> with <gdk/gdk.h>, and the gdk_x11_* calls with
gtk_window_present_with_time (GTK_WIDGET (window), GDK_CURRENT_TIME);
I found the that here: https://developer.gnome.org/gdk3/stable/gdk3-Events.html
I don't have available any environment other than gtk3-quartz to test it with though, so although it seems to work fine for me, I can't say if that is the best solution; I'm also not really a Gtk programmer.
The patch works fine in my testing, can we get it committed ?
The xid is used for the PackageKit calls to attach the PK dialogs to the Yelp window. Is this doable in Wayland? What's the current best practice?
(In reply to comment #3)
> The xid is used for the PackageKit calls to attach the PK dialogs to the Yelp
> window. Is this doable in Wayland? What's the current best practice?
No. However, it is not a great experience in X, and the general idea for evolving this addon functionality is to move away from these 'outer-body' attached dialogs, and instead require applications to provide proper UI if they want to sort of functionality.
ping ? would still be nice to get the patch merged
*** Bug 707254 has been marked as a duplicate of this bug. ***