GNOME Bugzilla – Bug 708165
videomixer: Store and forward tag events
Last modified: 2013-11-29 19:56:46 UTC
Created attachment 255035 [details] [review] fixes the reported issue We have race conditions highlighted by our integration test suite where these events were stickied and pushed on a flushing pad, send_event would just return FALSE (which, as already discussed in other instances, might be the real bug but it seemed it was too much of a hassle to change the prototype) The attached patch mimics adder's behaviour, which is to save these tags and forward them in collected. Should we open another bug "change send_event prototype eventually" ?
Looks good, but why only tag events? Why not also all other sticky events ?
Comment on attachment 255035 [details] [review] fixes the reported issue Not sure how to best handle other events too here. However this is not correct for tags. You need to accumulate/merge tags and always send the complete, currently valid tags downstream. I guess this also needs changes in adder then.
Created attachment 258306 [details] [review] New patch to correct the issue
Not sure about the merge macro to use, MERGE_APPEND seemed good to me but it might not be the good one.
commit 83f8ee1d41a238b2fc54c127eee8dee33390d08f Author: MathieuDuponchelle <mathieu.duponchelle@epitech.eu> Date: Sat Sep 14 03:27:09 2013 +0200 videomixer2: Merge tag events to send them in collected. Otherwise there were race conditions where we would send tags on a flushing srcpad. We have a test for that in GES, but this should be tested systematically with harness in the future as I believe it is useful for exactly that kind of cases. https://bugzilla.gnome.org/show_bug.cgi?id=708165