After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708162 - Build fails with "error: typedef 'GUPnPNetworkManager' locally defined but not used [-Werror=unused-local-typedefs]"
Build fails with "error: typedef 'GUPnPNetworkManager' locally defined but no...
Status: RESOLVED FIXED
Product: GUPnP
Classification: Other
Component: gupnp
unspecified
Other All
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-16 14:27 UTC by Emanuele Aina
Modified: 2013-09-17 08:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix GCC warnings about unused typedefs for local includes (2.04 KB, patch)
2013-09-16 14:27 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-09-16 14:27:22 UTC 
Moving the #include lines out of function scope and back to the global scope
makes GCC happier.
Comment 1 Emanuele Aina 2013-09-16 14:27:23 UTC 
Created attachment 255032 [details] [review]
Fix GCC warnings about unused typedefs for local includes

GCC was complaining with the following error:

 error: typedef 'GUPnPNetworkManager' locally defined but not used [-Werror=unused-local-typedefs]

Move the #include lines to the global scope to make it happy.

Alos use #ifdef/#if defined() consistently, instead of relying on the
defined values.
Comment 2 Jens Georg 2013-09-16 17:25:21 UTC 
Review of attachment 255032 [details] [review]:

yeah, makes sense
Comment 3 Emanuele Aina 2013-09-17 08:10:12 UTC 
The following fix has been pushed:
f16a62e Fix GCC warnings about unused typedefs for local includes