After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708160 - gnome-settings-daemon suspends on lid close even if docked
gnome-settings-daemon suspends on lid close even if docked
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-16 13:45 UTC by Giovanni Campagna
Modified: 2013-09-18 13:55 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
power: don't remove the inhibitor on laptop lid close (1.01 KB, patch)
2013-09-18 11:48 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-09-16 13:45:44 UTC 
Seems that g-s-d no longer recognizes I'm docked, and always suspends.
Comment 1 Bastien Nocera 2013-09-16 13:49:27 UTC 
g-s-d's power plugin has no code to check for "docked", it checks gnome-desktop for whether your laptop has an external display instead. I'm guessing that's broken...
Comment 2 Giovanni Campagna 2013-09-16 14:00:40 UTC 
(In reply to comment #1)
> g-s-d's power plugin has no code to check for "docked", it checks gnome-desktop
> for whether your laptop has an external display instead. I'm guessing that's
> broken...

Nope, I believe the problem is 1e14c67c (from bug 698132) - reverting that fixes it.
Comment 3 Matthias Clasen 2013-09-17 22:57:44 UTC 
We should probably sort this out for 3.10
Comment 4 Giovanni Campagna 2013-09-18 11:48:50 UTC 
Created attachment 255172 [details] [review]
power: don't remove the inhibitor on laptop lid close

If suspend_on_lid_close() returns FALSE, it means we should not
suspend, because there are external monitors, so we must not
remove the inhibitor (or logind will do the default thing, which
is suspending)
Comment 5 Bastien Nocera 2013-09-18 11:58:02 UTC 
Review of attachment 255172 [details] [review]:

As discussed on IRC, ack.
Comment 6 Giovanni Campagna 2013-09-18 13:55:16 UTC 
Pushed after r-t approval.
Attachment 255172 [details] pushed as e283537 - power: don't remove the inhibitor on laptop lid close