After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708116 - Crash in notification when the current track gets hidden while searching
Crash in notification when the current track gets hidden while searching
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-15 15:03 UTC by Arnel Borja
Modified: 2013-09-16 08:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
player: Don't emit playing-changed when the bus state changes (999 bytes, patch)
2013-09-15 15:03 UTC, Arnel Borja
committed Details | Review

Description Arnel Borja 2013-09-15 15:03:03 UTC
To reproduce:
1. Play a song in Songs view.
2. Open search bar then do a search that will hide the current track.
3. Move the scrollbar (you might have to do it several times)

Music will then crash because the current media returned by Player is None.
Comment 1 Arnel Borja 2013-09-15 15:03:06 UTC
Created attachment 254979 [details] [review]
player: Don't emit playing-changed when the bus state changes

This causes a crash in notification when the current track gets hidden
on filtering, but when the bus state changes, it doesn't mean that the
current track changed.
Comment 2 Vadim Rutkovsky 2013-09-16 08:04:50 UTC
Review of attachment 254979 [details] [review]:

Looks good to me
Comment 3 Arnel Borja 2013-09-16 08:43:07 UTC
Comment on attachment 254979 [details] [review]
player: Don't emit playing-changed when the bus state changes

Committed as e78781e7.